diff mbox

libnss: workaround for microblaze ld bug

Message ID 20170218214001.GA342@waldemar-brodkorb.de
State Accepted
Commit fceb1afd5dda45cf180f22877a6ab0e51d1b3dac
Headers show

Commit Message

Waldemar Brodkorb Feb. 18, 2017, 9:40 p.m. UTC
Add a workaround for a microblaze specific ld bug to avoid
segfault.

Fixes:
  http://autobuild.buildroot.net/results/638a65453879777a0d5bdb29231034cd261b41c0

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/libnss/libnss.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Peter Korsgaard Feb. 19, 2017, 9:15 p.m. UTC | #1
>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > Add a workaround for a microblaze specific ld bug to avoid
 > segfault.

 > Fixes:
 >   http://autobuild.buildroot.net/results/638a65453879777a0d5bdb29231034cd261b41c0

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
 > ---
 >  package/libnss/libnss.mk | 10 ++++++++++
 >  1 file changed, 10 insertions(+)

 > diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
 > index 4a40b0a..5683ffc 100644
 > --- a/package/libnss/libnss.mk
 > +++ b/package/libnss/libnss.mk
 > @@ -13,6 +13,16 @@ LIBNSS_DEPENDENCIES = libnspr sqlite zlib
 >  LIBNSS_LICENSE = MPLv2.0
 >  LIBNSS_LICENSE_FILES = nss/COPYING
 
 > +# --gc-sections triggers binutils ld segfault
 > +# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
 > +ifeq ($(BR2_microblaze),y)
 > +define LIBNSS_PRECONFIGURE
 > +	sed -i 's:-Wl,--gc-sections::g' $(@D)/nss/coreconf/Linux.mk
 > +endef
 > +
 > +LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_PRECONFIGURE

Renamed to LIBNSS_DROP_GC_SECTIONS and committed, thanks!
diff mbox

Patch

diff --git a/package/libnss/libnss.mk b/package/libnss/libnss.mk
index 4a40b0a..5683ffc 100644
--- a/package/libnss/libnss.mk
+++ b/package/libnss/libnss.mk
@@ -13,6 +13,16 @@  LIBNSS_DEPENDENCIES = libnspr sqlite zlib
 LIBNSS_LICENSE = MPLv2.0
 LIBNSS_LICENSE_FILES = nss/COPYING
 
+# --gc-sections triggers binutils ld segfault
+# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
+ifeq ($(BR2_microblaze),y)
+define LIBNSS_PRECONFIGURE
+	sed -i 's:-Wl,--gc-sections::g' $(@D)/nss/coreconf/Linux.mk
+endef
+
+LIBNSS_PRE_CONFIGURE_HOOKS += LIBNSS_PRECONFIGURE
+endif
+
 LIBNSS_BUILD_VARS = \
 	MOZILLA_CLIENT=1 \
 	NSPR_INCLUDE_DIR=$(STAGING_DIR)/usr/include/nspr \