diff mbox

[ovs-dev,3/3] Makefile.am: Avoid including internal library in public header files.

Message ID 1487382465-38640-3-git-send-email-yihung.wei@gmail.com
State Accepted
Headers show

Commit Message

Yi-Hung Wei Feb. 18, 2017, 1:47 a.m. UTC
Add a build check that public openvswitch header file should not include
internal library.

Suggested-by: Joe Stringer <joe@ovn.org>
Suggested-by: Daniele Di Proietto <diproiettod@vmware.com>
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
---
 Makefile.am | 7 +++++++
 1 file changed, 7 insertions(+)
diff mbox

Patch

diff --git a/Makefile.am b/Makefile.am
index 4b1b48d..7126ebe 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -230,6 +230,13 @@  config-h-check:
 	  echo "every C source file must #include <config.h>."; \
 	  exit 1; \
 	fi
+	if grep '#include' include/openvswitch/*.h | \
+	    grep -vE '(<.*>)|("openvswitch)|("openflow)'; \
+	then \
+	  echo "See above for list of violations of the rule that"; \
+	  echo "public openvswitch header file should not include internal library."; \
+	  exit 1; \
+	fi
 .PHONY: config-h-check
 
 # Check for printf() type modifiers that MSVC doesn't support.