| Message ID | 1487382465-38640-1-git-send-email-yihung.wei@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On 17 February 2017 at 17:47, Yi-Hung Wei <yihung.wei@gmail.com> wrote: > Remove unnecessary #include in ofp-msgs.h so that make will not complain. > > Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com> > --- Not sure about make complaining, but this include does seem to be both unnecessary and a violation of including internal libraries from the public headers. Thanks, applied to master.
On 21 February 2017 at 11:37, Joe Stringer <joe@ovn.org> wrote: > On 17 February 2017 at 17:47, Yi-Hung Wei <yihung.wei@gmail.com> wrote: >> Remove unnecessary #include in ofp-msgs.h so that make will not complain. >> >> Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com> >> --- > > Not sure about make complaining, but this include does seem to be both > unnecessary and a violation of including internal libraries from the > public headers. > > Thanks, applied to master. I also applied this series to branch-2.7.
diff --git a/include/openvswitch/ofp-msgs.h b/include/openvswitch/ofp-msgs.h index ffb88b3..07fd8aa 100644 --- a/include/openvswitch/ofp-msgs.h +++ b/include/openvswitch/ofp-msgs.h @@ -40,7 +40,6 @@ #include "openvswitch/ofp-errors.h" #include "openvswitch/types.h" -#include "util.h" struct ovs_list;
Remove unnecessary #include in ofp-msgs.h so that make will not complain. Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com> --- include/openvswitch/ofp-msgs.h | 1 - 1 file changed, 1 deletion(-)