From patchwork Wed Nov 24 15:52:54 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 72916 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 30C6AB7080 for ; Thu, 25 Nov 2010 03:16:19 +1100 (EST) Received: from localhost ([127.0.0.1]:46819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLI12-0006lg-Ng for incoming@patchwork.ozlabs.org; Wed, 24 Nov 2010 11:16:16 -0500 Received: from [140.186.70.92] (port=48319 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLHnn-0007dU-P0 for qemu-devel@nongnu.org; Wed, 24 Nov 2010 11:02:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLHeg-0004gL-5j for qemu-devel@nongnu.org; Wed, 24 Nov 2010 10:55:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLHef-0004g5-TC for qemu-devel@nongnu.org; Wed, 24 Nov 2010 10:53:10 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAOFr77q025922 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Nov 2010 10:53:07 -0500 Received: from redhat.com (vpn-8-143.rdu.redhat.com [10.11.8.143]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id oAOFr4a7027187; Wed, 24 Nov 2010 10:53:05 -0500 Date: Wed, 24 Nov 2010 17:52:54 +0200 From: "Michael S. Tsirkin" To: jasowang@redhat.com, Anthony Liguori , qemu-devel@nongnu.org, quintela@redhat.com Message-ID: <0c2beda8b93896b69ddd765814d111be86f86526.1290613959.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mutt-Fcc: =sent User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCHv2 1/6] virtio-net: don't dma while vm is stopped X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org DMA into memory while VM is stopped makes it hard to debug migration (consequitive saves result in different files). Fixing this completely is a large effort, this patch does this for virtio-net. Signed-off-by: Michael S. Tsirkin Tested-by: Jason Wang --- hw/virtio-net.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 1d61f19..43a2b3d 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -424,6 +424,9 @@ static void virtio_net_handle_rx(VirtIODevice *vdev, VirtQueue *vq) static int virtio_net_can_receive(VLANClientState *nc) { VirtIONet *n = DO_UPCAST(NICState, nc, nc)->opaque; + if (!n->vm_running) { + return 0; + } if (!virtio_queue_ready(n->rx_vq) || !(n->vdev.status & VIRTIO_CONFIG_S_DRIVER_OK))