From patchwork Wed Nov 24 15:53:02 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 72912 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A964CB708B for ; Thu, 25 Nov 2010 03:09:17 +1100 (EST) Received: from localhost ([127.0.0.1]:45859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLHuE-0002am-G4 for incoming@patchwork.ozlabs.org; Wed, 24 Nov 2010 11:09:14 -0500 Received: from [140.186.70.92] (port=48289 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLHng-0007cx-3V for qemu-devel@nongnu.org; Wed, 24 Nov 2010 11:02:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLHem-0004iP-I1 for qemu-devel@nongnu.org; Wed, 24 Nov 2010 10:55:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLHem-0004i5-Av for qemu-devel@nongnu.org; Wed, 24 Nov 2010 10:53:16 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAOFrETg030068 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Nov 2010 10:53:14 -0500 Received: from redhat.com (vpn-8-143.rdu.redhat.com [10.11.8.143]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id oAOFrCLZ015362; Wed, 24 Nov 2010 10:53:12 -0500 Date: Wed, 24 Nov 2010 17:53:02 +0200 From: "Michael S. Tsirkin" To: jasowang@redhat.com, Anthony Liguori , qemu-devel@nongnu.org, quintela@redhat.com Message-ID: <5e41c7e3293678809cb901185bd9393d0976c614.1290613959.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mutt-Fcc: =sent User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCHv2 3/6] migration/savevm: no need to flush requests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org There's no need to flush requests after vmstop as vmstop does it for us automatically now. Signed-off-by: Michael S. Tsirkin Tested-by: Jason Wang --- migration.c | 2 -- savevm.c | 4 ---- 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/migration.c b/migration.c index 9ee8b17..15f7f35 100644 --- a/migration.c +++ b/migration.c @@ -368,8 +368,6 @@ void migrate_fd_put_ready(void *opaque) DPRINTF("done iterating\n"); vm_stop(0); - qemu_aio_flush(); - bdrv_flush_all(); if ((qemu_savevm_state_complete(s->mon, s->file)) < 0) { if (old_vm_running) { vm_start(); diff --git a/savevm.c b/savevm.c index 4e49765..49e78a5 100644 --- a/savevm.c +++ b/savevm.c @@ -1575,8 +1575,6 @@ static int qemu_savevm_state(Monitor *mon, QEMUFile *f) saved_vm_running = vm_running; vm_stop(0); - bdrv_flush_all(); - ret = qemu_savevm_state_begin(mon, f, 0, 0); if (ret < 0) goto out; @@ -1885,8 +1883,6 @@ void do_savevm(Monitor *mon, const QDict *qdict) monitor_printf(mon, "No block device can accept snapshots\n"); return; } - /* ??? Should this occur after vm_stop? */ - qemu_aio_flush(); saved_vm_running = vm_running; vm_stop(0);