| Message ID | 20170216204116.2212-1-joerg.krause@embedded.rocks |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Thu, 16 Feb 2017 21:41:15 +0100, Jörg Krause wrote: > Building wavpack using a toolchain without wchar support fails: > > ``` > import_id3.c:37:34: error: unknown type name 'wchar_t' > ``` > > Fixes: > http://autobuild.buildroot.net/results/9a6/9a693f5b798571917f36cfb7661e2f2638aac550/ > http://autobuild.buildroot.net/results/44c/44c8227043045baf4f043da44b8129e43dfff687/ > http://autobuild.buildroot.net/results/a80/a80221dcc0860046ebdf0bbf454e056b1e20df83/ > .. and more. > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> This dependency is only needed for one specific tool in wavpack added by the recent bump to 5.1.0. So I've reported this issue upstream: https://github.com/dbry/WavPack/issues/19 But OK, I agree we don't really care if wavpack needs wchar support, so we certainly don't need to wait for the answer to this upstream bug report. > diff --git a/package/wavpack/Config.in b/package/wavpack/Config.in > index 1ef3e420d..5a27b2e15 100644 > --- a/package/wavpack/Config.in > +++ b/package/wavpack/Config.in > @@ -1,8 +1,12 @@ > config BR2_PACKAGE_WAVPACK > bool "wavpack" > + depends on BR2_USE_WCHAR None of the places that select wavpack need to be fixed for the wchar dependency? package/gstreamer/gst-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK package/gstreamer1/gst1-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK package/mpd/Config.in: select BR2_PACKAGE_WAVPACK From a quick look, it seems to be OK, but it would have been to indicate it in the commit log (and maybe update the comments in those packages to explain why we have the wchar dependency). Thanks! Thomas
Hi Thomas, Am Thu, 16 Feb 2017 22:19:07 +0100 schrieb Thomas Petazzoni: > None of the places that select wavpack need to be fixed for the wchar > dependency? > > package/gstreamer/gst-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK "depends on BR2_USE_WCHAR" needs to be backported, same was valid for BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC. > package/gstreamer1/gst1-plugins-good/Config.in: select BR2_PACKAGE_WAVPACK "depends on BR2_USE_WCHAR" needs to be backported, same was valid for BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB. > package/mpd/Config.in: select BR2_PACKAGE_WAVPACK mpd itself depends on BR2_USE_WCHAR, no backport needed. Regards, Bernd
Hi Thomas, Hi Bernd, On Fri, 2017-02-17 at 06:06 +0100, Bernd Kuhls wrote: > Hi Thomas, > > Am Thu, 16 Feb 2017 22:19:07 +0100 schrieb Thomas Petazzoni: > > > None of the places that select wavpack need to be fixed for the > > wchar > > dependency? > > > > package/gstreamer/gst-plugins-good/Config.in: select > > BR2_PACKAGE_WAVPACK > > "depends on BR2_USE_WCHAR" needs to be backported, same was valid > for BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLAC. > > > package/gstreamer1/gst1-plugins-good/Config.in: select > > BR2_PACKAGE_WAVPACK > > "depends on BR2_USE_WCHAR" needs to be backported, same was valid > for BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB. > > > package/mpd/Config.in: select BR2_PACKAGE_WAVPACK > > mpd itself depends on BR2_USE_WCHAR, no backport needed. > Upstream committed a fix [1] (thanks to Thomas for reporting the issue) which drops the dependency on wchar. Maybe we should apply this to remove BR2_USE_WCHAR? [1] https://github.com/dbry/WavPack/commit/876fc3f3907e871d0938ac6c8c52 52f5f31abd1f Jörg
Hello, On Fri, 17 Feb 2017 08:12:02 +0100, Jörg Krause wrote: > Upstream committed a fix [1] (thanks to Thomas for reporting the issue) > which drops the dependency on wchar. Maybe we should apply this to > remove BR2_USE_WCHAR? Yes, it would be best. Could you send a patch for this, of course after checking it really fixes the build for a non-wchar toolchain. Thanks! Thomas
diff --git a/package/wavpack/Config.in b/package/wavpack/Config.in index 1ef3e420d..5a27b2e15 100644 --- a/package/wavpack/Config.in +++ b/package/wavpack/Config.in @@ -1,8 +1,12 @@ config BR2_PACKAGE_WAVPACK bool "wavpack" + depends on BR2_USE_WCHAR select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help WavPack is a completely open audio compression format providing lossless, high-quality lossy, and a unique hybrid compression mode. http://www.wavpack.com/ + +comment "wavpack needs a toolchain w/ wchar" + depends on !BR2_USE_WCHAR
Building wavpack using a toolchain without wchar support fails: ``` import_id3.c:37:34: error: unknown type name 'wchar_t' ``` Fixes: http://autobuild.buildroot.net/results/9a6/9a693f5b798571917f36cfb7661e2f2638aac550/ http://autobuild.buildroot.net/results/44c/44c8227043045baf4f043da44b8129e43dfff687/ http://autobuild.buildroot.net/results/a80/a80221dcc0860046ebdf0bbf454e056b1e20df83/ .. and more. Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- package/wavpack/Config.in | 4 ++++ 1 file changed, 4 insertions(+)