| Message ID | 20170216060050.20866-1-anton@ozlabs.org |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > From: Anton Blanchard <anton@samba.org> > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > use the plurals. > > Signed-off-by: Anton Blanchard <anton@samba.org> this rename made me notice that UPROBE_EVENTS still defaults to 'n'. this is key feature that all distros enable, so having default 'n' is kinda saying that it's not something that should be turned on or used widely. which is obviously not the case. imo it's time to change it to 'y'. Thoughts? -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Added more people to the CC list. Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > use the plurals. > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > this is key feature that all distros enable, so having default 'n' > is kinda saying that it's not something that should be turned on > or used widely. which is obviously not the case. > imo it's time to change it to 'y'. > Thoughts? Agreed, I also found it strange that it was disabled by default when I recently did a 'make oldconfig' :-\ - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote: > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: >>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as >>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently >>> use the plurals. > >> this rename made me notice that UPROBE_EVENTS still defaults to 'n'. >> this is key feature that all distros enable, so having default 'n' >> is kinda saying that it's not something that should be turned on >> or used widely. which is obviously not the case. >> imo it's time to change it to 'y'. >> Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it should default on. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 15, 2017 at 07:10:56PM -0600, David Ahern wrote: > On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote: > > Added more people to the CC list. > > > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > >>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > >>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > >>> use the plurals. > > > >> this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > >> this is key feature that all distros enable, so having default 'n' > >> is kinda saying that it's not something that should be turned on > >> or used widely. which is obviously not the case. > >> imo it's time to change it to 'y'. > >> Thoughts? > > > > Agreed, I also found it strange that it was disabled by default when I > > recently did a 'make oldconfig' :-\ > > Debian stretch, Ubuntu 16.10, Fedora 26 all have it enabled. Perhaps it > should default on. +1 Archlinux also has it enabled. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > > use the plurals. > > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > > this is key feature that all distros enable, so having default 'n' > > is kinda saying that it's not something that should be turned on > > or used widely. which is obviously not the case. > > imo it's time to change it to 'y'. > > Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Yes, we could make it default on. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017/3/16 9:06, Arnaldo Carvalho de Melo wrote: > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: >>> We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as >>> well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently >>> use the plurals. > >> this rename made me notice that UPROBE_EVENTS still defaults to 'n'. >> this is key feature that all distros enable, so having default 'n' >> is kinda saying that it's not something that should be turned on >> or used widely. which is obviously not the case. >> imo it's time to change it to 'y'. >> Thoughts? > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ > > - Arnaldo +1. Some internal distros in my company now have started discussing supporting user space probing. Turning uprobes on for upstream kernel helps us saving a lot of discussion. Thank you. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > > use the plurals. > > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > > this is key feature that all distros enable, so having default 'n' > > is kinda saying that it's not something that should be turned on > > or used widely. which is obviously not the case. > > imo it's time to change it to 'y'. > > Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Agreed, someone please send a patch (or feel free to include it in the perf tooling tree) to switch the default around. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 15 Mar 2017 22:06:51 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Added more people to the CC list. > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > > use the plurals. > > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > > this is key feature that all distros enable, so having default 'n' > > is kinda saying that it's not something that should be turned on > > or used widely. which is obviously not the case. > > imo it's time to change it to 'y'. > > Thoughts? > > Agreed, I also found it strange that it was disabled by default when I > recently did a 'make oldconfig' :-\ Agreed. Now uprobes is enough stable. (and widely used) Thanks!
Em Thu, Mar 16, 2017 at 07:40:55AM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > > Added more people to the CC list. > > > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > > > On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wrote: > > > > We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as > > > > well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently > > > > use the plurals. > > > > > this rename made me notice that UPROBE_EVENTS still defaults to 'n'. > > > this is key feature that all distros enable, so having default 'n' > > > is kinda saying that it's not something that should be turned on > > > or used widely. which is obviously not the case. > > > imo it's time to change it to 'y'. > > > Thoughts? > > > > Agreed, I also found it strange that it was disabled by default when I > > recently did a 'make oldconfig' :-\ > > Agreed, someone please send a patch (or feel free to include it in the perf > tooling tree) to switch the default around. Ok, will collect the agreements as Acked-by tags and put it in perf/core. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt index e4991fb..41ef9d8 100644 --- a/Documentation/trace/kprobetrace.txt +++ b/Documentation/trace/kprobetrace.txt @@ -12,7 +12,7 @@ kprobes can probe (this means, all functions body except for __kprobes functions). Unlike the Tracepoint based event, this can be added and removed dynamically, on the fly. -To enable this feature, build your kernel with CONFIG_KPROBE_EVENT=y. +To enable this feature, build your kernel with CONFIG_KPROBE_EVENTS=y. Similar to the events tracer, this doesn't need to be activated via current_tracer. Instead of that, add probe points via diff --git a/Documentation/trace/uprobetracer.txt b/Documentation/trace/uprobetracer.txt index fa7b680..bf526a7c 100644 --- a/Documentation/trace/uprobetracer.txt +++ b/Documentation/trace/uprobetracer.txt @@ -7,7 +7,7 @@ Overview -------- Uprobe based trace events are similar to kprobe based trace events. -To enable this feature, build your kernel with CONFIG_UPROBE_EVENT=y. +To enable this feature, build your kernel with CONFIG_UPROBE_EVENTS=y. Similar to the kprobe-event tracer, this doesn't need to be activated via current_tracer. Instead of that, add probe points via diff --git a/arch/powerpc/configs/85xx/kmp204x_defconfig b/arch/powerpc/configs/85xx/kmp204x_defconfig index aaaaa60..34a4da2 100644 --- a/arch/powerpc/configs/85xx/kmp204x_defconfig +++ b/arch/powerpc/configs/85xx/kmp204x_defconfig @@ -210,7 +210,7 @@ CONFIG_DEBUG_SHIRQ=y CONFIG_DETECT_HUNG_TASK=y CONFIG_SCHEDSTATS=y CONFIG_RCU_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_CRYPTO_NULL=y CONFIG_CRYPTO_PCBC=m CONFIG_CRYPTO_MD4=y diff --git a/arch/s390/configs/default_defconfig b/arch/s390/configs/default_defconfig index e0097536..53d7cbb 100644 --- a/arch/s390/configs/default_defconfig +++ b/arch/s390/configs/default_defconfig @@ -609,7 +609,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y diff --git a/arch/s390/configs/gcov_defconfig b/arch/s390/configs/gcov_defconfig index f05d2d6..0de46cc 100644 --- a/arch/s390/configs/gcov_defconfig +++ b/arch/s390/configs/gcov_defconfig @@ -560,7 +560,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y diff --git a/arch/s390/configs/performance_defconfig b/arch/s390/configs/performance_defconfig index 2cf8734..e77f0dc 100644 --- a/arch/s390/configs/performance_defconfig +++ b/arch/s390/configs/performance_defconfig @@ -558,7 +558,7 @@ CONFIG_SCHED_TRACER=y CONFIG_FTRACE_SYSCALLS=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_HIST_TRIGGERS=y CONFIG_TRACE_ENUM_MAP_FILE=y diff --git a/arch/s390/defconfig b/arch/s390/defconfig index d00e368..0732a7f 100644 --- a/arch/s390/defconfig +++ b/arch/s390/defconfig @@ -179,7 +179,7 @@ CONFIG_FTRACE_SYSCALLS=y CONFIG_TRACER_SNAPSHOT_PER_CPU_SWAP=y CONFIG_STACK_TRACER=y CONFIG_BLK_DEV_IO_TRACE=y -CONFIG_UPROBE_EVENT=y +CONFIG_UPROBE_EVENTS=y CONFIG_FUNCTION_PROFILER=y CONFIG_TRACE_ENUM_MAP_FILE=y CONFIG_KPROBES_SANITY_TEST=y diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index d503800..d4a06e7 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -429,7 +429,7 @@ config BLK_DEV_IO_TRACE If unsure, say N. -config KPROBE_EVENT +config KPROBE_EVENTS depends on KPROBES depends on HAVE_REGS_AND_STACK_ACCESS_API bool "Enable kprobes-based dynamic events" @@ -447,7 +447,7 @@ config KPROBE_EVENT This option is also required by perf-probe subcommand of perf tools. If you want to use perf tools, this option is strongly recommended. -config UPROBE_EVENT +config UPROBE_EVENTS bool "Enable uprobes-based dynamic events" depends on ARCH_SUPPORTS_UPROBES depends on MMU @@ -466,7 +466,7 @@ config UPROBE_EVENT config BPF_EVENTS depends on BPF_SYSCALL - depends on (KPROBE_EVENT || UPROBE_EVENT) && PERF_EVENTS + depends on (KPROBE_EVENTS || UPROBE_EVENTS) && PERF_EVENTS bool default y help diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile index e579808..90f2701 100644 --- a/kernel/trace/Makefile +++ b/kernel/trace/Makefile @@ -57,7 +57,7 @@ obj-$(CONFIG_EVENT_TRACING) += trace_events_filter.o obj-$(CONFIG_EVENT_TRACING) += trace_events_trigger.o obj-$(CONFIG_HIST_TRIGGERS) += trace_events_hist.o obj-$(CONFIG_BPF_EVENTS) += bpf_trace.o -obj-$(CONFIG_KPROBE_EVENT) += trace_kprobe.o +obj-$(CONFIG_KPROBE_EVENTS) += trace_kprobe.o obj-$(CONFIG_TRACEPOINTS) += power-traces.o ifeq ($(CONFIG_PM),y) obj-$(CONFIG_TRACEPOINTS) += rpm-traces.o @@ -66,7 +66,7 @@ ifeq ($(CONFIG_TRACING),y) obj-$(CONFIG_KGDB_KDB) += trace_kdb.o endif obj-$(CONFIG_PROBE_EVENTS) += trace_probe.o -obj-$(CONFIG_UPROBE_EVENT) += trace_uprobe.o +obj-$(CONFIG_UPROBE_EVENTS) += trace_uprobe.o obj-$(CONFIG_TRACEPOINT_BENCHMARK) += trace_benchmark.o diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d744978..9a8b415 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -4348,22 +4348,22 @@ static const char readme_msg[] = "\t\t\t traces\n" #endif #endif /* CONFIG_STACK_TRACER */ -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS " kprobe_events\t\t- Add/remove/show the kernel dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n" #endif -#ifdef CONFIG_UPROBE_EVENT +#ifdef CONFIG_UPROBE_EVENTS " uprobe_events\t\t- Add/remove/show the userspace dynamic events\n" "\t\t\t Write into this file to define/undefine new trace events.\n" #endif -#if defined(CONFIG_KPROBE_EVENT) || defined(CONFIG_UPROBE_EVENT) +#if defined(CONFIG_KPROBE_EVENTS) || defined(CONFIG_UPROBE_EVENTS) "\t accepts: event-definitions (one definition per line)\n" "\t Format: p|r[:[<group>/]<event>] <place> [<args>]\n" "\t -:[<group>/]<event>\n" -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS "\t place: [<module>:]<symbol>[+<offset>]|<memaddr>\n" #endif -#ifdef CONFIG_UPROBE_EVENT +#ifdef CONFIG_UPROBE_EVENTS "\t place: <path>:<offset>\n" #endif "\t args: <name>=fetcharg[:type]\n" diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index 0c0ae54..903273c 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -248,7 +248,7 @@ ASSIGN_FETCH_FUNC(file_offset, ftype), \ #define FETCH_TYPE_STRING 0 #define FETCH_TYPE_STRSIZE 1 -#ifdef CONFIG_KPROBE_EVENT +#ifdef CONFIG_KPROBE_EVENTS struct symbol_cache; unsigned long update_symbol_cache(struct symbol_cache *sc); void free_symbol_cache(struct symbol_cache *sc); @@ -278,7 +278,7 @@ alloc_symbol_cache(const char *sym, long offset) { return NULL; } -#endif /* CONFIG_KPROBE_EVENT */ +#endif /* CONFIG_KPROBE_EVENTS */ struct probe_arg { struct fetch_param fetch;