| Message ID | 1b6f2fe681fd1b540a55c879c258a31bdea6e0e1.1487187192.git.pavel.belous@aquantia.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 15.02.2017 21:01, Pavel Belous wrote: > From: Pavel Belous <pavel.belous@aquantia.com> > > Use NETDEV_TX_OK as the return value for successful transmission. > > Signed-off-by: Pavel Belous <pavel.belous@aquantia.com> > --- > drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c > index 1bf5975..4cf633c 100644 > --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c > +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c > @@ -567,7 +567,7 @@ __acquires(&ring->lock) > unsigned int vec = skb->queue_mapping % self->aq_nic_cfg.vecs; > unsigned int tc = 0U; > unsigned int trys = AQ_CFG_LOCK_TRYS; > - int err = 0; > + int err = NETDEV_TX_OK; > bool is_nic_in_bad_state; > struct aq_ring_buff_s buffers[AQ_CFG_SKB_FRAGS_MAX]; > > Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de> Regards, Lino
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 1bf5975..4cf633c 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -567,7 +567,7 @@ __acquires(&ring->lock) unsigned int vec = skb->queue_mapping % self->aq_nic_cfg.vecs; unsigned int tc = 0U; unsigned int trys = AQ_CFG_LOCK_TRYS; - int err = 0; + int err = NETDEV_TX_OK; bool is_nic_in_bad_state; struct aq_ring_buff_s buffers[AQ_CFG_SKB_FRAGS_MAX];