diff mbox

[U-Boot] driver: net: ldpaa: Update priv->phydev after free()

Message ID 1487171690-26677-1-git-send-email-Ashish.Kumar@nxp.com
State Superseded
Headers show

Commit Message

Ashish Kumar Feb. 15, 2017, 3:14 p.m. UTC 
From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>

Even after memory free of phydev, priv is still pointing to the
obsolete address.
So update priv->phydev as NULL after memory free.

Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
 drivers/net/ldpaa_eth/ldpaa_eth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Joe Hershberger Aug. 11, 2017, 6:43 p.m. UTC | #1 
On Wed, Feb 15, 2017 at 9:14 AM, Ashish Kumar <Ashish.Kumar@nxp.com> wrote:
> From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>
> Even after memory free of phydev, priv is still pointing to the
> obsolete address.
> So update priv->phydev as NULL after memory free.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
diff mbox

Patch

diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c b/drivers/net/ldpaa_eth/ldpaa_eth.c
index 4e61700..f235b62 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.c
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
@@ -587,8 +587,10 @@  static void ldpaa_eth_stop(struct eth_device *net_dev)
 #ifdef CONFIG_PHYLIB
 	if (priv->phydev && bus != NULL)
 		phy_shutdown(priv->phydev);
-	else
+	else {
 		free(priv->phydev);
+		priv->phydev = NULL;
+	}
 #endif
 
 	ldpaa_dpbp_free();