[gomp4] Async related additions to OpenACC runtime library

Hi Chung-Lin!

On Mon, 13 Feb 2017 18:13:42 +0800, Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
> Tested and committed to gomp-4_0-branch.

Thanks!  (Not yet reviewed.)  Testing this, I saw a lot of regressions,
and in r245427 just committed the following to gomp-4_0-branch to address
OCthese.  Did you simply forget to commit your changes to
libgomp/libgomp.map, or why did this work for you?  Please verify:

commit bd5613600754bd7a1fe85990eb3b7b6b5f2e1543
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Tue Feb 14 11:20:31 2017 +0000

    Update libgomp/libgomp.map for OpenACC async functions
    
            libgomp/
            * libgomp.map: Add OACC_2.5 version, and add acc_copyin_async,
            acc_copyin_async_32_h_, acc_copyin_async_64_h_,
            acc_copyin_async_array_h_, acc_copyout_async,
            acc_copyout_async_32_h_, acc_copyout_async_64_h_,
            acc_copyout_async_array_h_, acc_create_async,
            acc_create_async_32_h_, acc_create_async_64_h_,
            acc_create_async_array_h_, acc_delete_async,
            acc_delete_async_32_h_, acc_delete_async_64_h_,
            acc_delete_async_array_h_, acc_get_default_async,
            acc_get_default_async_h_, acc_memcpy_from_device_async,
            acc_memcpy_to_device_async, acc_set_default_async,
            acc_set_default_async_h_, acc_update_device_async,
            acc_update_device_async_32_h_, acc_update_device_async_64_h_,
            acc_update_device_async_array_h_, acc_update_self_async,
            acc_update_self_async_32_h_, acc_update_self_async_64_h_, and
            acc_update_self_async_array_h_.  Add GOMP_PLUGIN_1.2 version, and
            add GOMP_PLUGIN_acc_thread_default_async.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@245427 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog.gomp | 20 ++++++++++++++++++++
 libgomp/libgomp.map    | 39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)



Grüße
 Thomas

On 2017/2/14 07:25 PM, Thomas Schwinge wrote:
> Hi Chung-Lin!
> 
> On Mon, 13 Feb 2017 18:13:42 +0800, Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
>> Tested and committed to gomp-4_0-branch.
> 
> Thanks!  (Not yet reviewed.)  Testing this, I saw a lot of regressions,
> and in r245427 just committed the following to gomp-4_0-branch to address
> OCthese.  Did you simply forget to commit your changes to
> libgomp/libgomp.map, or why did this work for you?  Please verify:

Weird, I did not see any regressions, but thanks for adding those.
I overlooked updating the map file.

Thanks,
Chung-Lin

> commit bd5613600754bd7a1fe85990eb3b7b6b5f2e1543
> Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date:   Tue Feb 14 11:20:31 2017 +0000
> 
>     Update libgomp/libgomp.map for OpenACC async functions
>     
>             libgomp/
>             * libgomp.map: Add OACC_2.5 version, and add acc_copyin_async,
>             acc_copyin_async_32_h_, acc_copyin_async_64_h_,
>             acc_copyin_async_array_h_, acc_copyout_async,
>             acc_copyout_async_32_h_, acc_copyout_async_64_h_,
>             acc_copyout_async_array_h_, acc_create_async,
>             acc_create_async_32_h_, acc_create_async_64_h_,
>             acc_create_async_array_h_, acc_delete_async,
>             acc_delete_async_32_h_, acc_delete_async_64_h_,
>             acc_delete_async_array_h_, acc_get_default_async,
>             acc_get_default_async_h_, acc_memcpy_from_device_async,
>             acc_memcpy_to_device_async, acc_set_default_async,
>             acc_set_default_async_h_, acc_update_device_async,
>             acc_update_device_async_32_h_, acc_update_device_async_64_h_,
>             acc_update_device_async_array_h_, acc_update_self_async,
>             acc_update_self_async_32_h_, acc_update_self_async_64_h_, and
>             acc_update_self_async_array_h_.  Add GOMP_PLUGIN_1.2 version, and
>             add GOMP_PLUGIN_acc_thread_default_async.
>     
>     git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@245427 138bc75d-0d04-0410-961f-82ee72b054a4
> ---
>  libgomp/ChangeLog.gomp | 20 ++++++++++++++++++++
>  libgomp/libgomp.map    | 39 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+)
> 
> diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp
> index 0a5f601..b811c28 100644
> --- libgomp/ChangeLog.gomp
> +++ libgomp/ChangeLog.gomp
> @@ -1,3 +1,23 @@
> +2017-02-14  Thomas Schwinge  <thomas@codesourcery.com>
> +
> +	* libgomp.map: Add OACC_2.5 version, and add acc_copyin_async,
> +	acc_copyin_async_32_h_, acc_copyin_async_64_h_,
> +	acc_copyin_async_array_h_, acc_copyout_async,
> +	acc_copyout_async_32_h_, acc_copyout_async_64_h_,
> +	acc_copyout_async_array_h_, acc_create_async,
> +	acc_create_async_32_h_, acc_create_async_64_h_,
> +	acc_create_async_array_h_, acc_delete_async,
> +	acc_delete_async_32_h_, acc_delete_async_64_h_,
> +	acc_delete_async_array_h_, acc_get_default_async,
> +	acc_get_default_async_h_, acc_memcpy_from_device_async,
> +	acc_memcpy_to_device_async, acc_set_default_async,
> +	acc_set_default_async_h_, acc_update_device_async,
> +	acc_update_device_async_32_h_, acc_update_device_async_64_h_,
> +	acc_update_device_async_array_h_, acc_update_self_async,
> +	acc_update_self_async_32_h_, acc_update_self_async_64_h_, and
> +	acc_update_self_async_array_h_.  Add GOMP_PLUGIN_1.2 version, and
> +	add GOMP_PLUGIN_acc_thread_default_async.
> +
>  2017-02-13  Cesar Philippidis  <cesar@codesourcery.com>
>  
>  	* plugin/plugin-nvptx.c (nvptx_exec): Adjust the default num_gangs.
> diff --git libgomp/libgomp.map libgomp/libgomp.map
> index b047ad9..2c9a13d 100644
> --- libgomp/libgomp.map
> +++ libgomp/libgomp.map
> @@ -378,6 +378,40 @@ OACC_2.0 {
>  	acc_set_cuda_stream;
>  };
>  
> +OACC_2.5 {
> +  global:
> +	acc_copyin_async;
> +	acc_copyin_async_32_h_;
> +	acc_copyin_async_64_h_;
> +	acc_copyin_async_array_h_;
> +	acc_copyout_async;
> +	acc_copyout_async_32_h_;
> +	acc_copyout_async_64_h_;
> +	acc_copyout_async_array_h_;
> +	acc_create_async;
> +	acc_create_async_32_h_;
> +	acc_create_async_64_h_;
> +	acc_create_async_array_h_;
> +	acc_delete_async;
> +	acc_delete_async_32_h_;
> +	acc_delete_async_64_h_;
> +	acc_delete_async_array_h_;
> +	acc_get_default_async;
> +	acc_get_default_async_h_;
> +	acc_memcpy_from_device_async;
> +	acc_memcpy_to_device_async;
> +	acc_set_default_async;
> +	acc_set_default_async_h_;
> +	acc_update_device_async;
> +	acc_update_device_async_32_h_;
> +	acc_update_device_async_64_h_;
> +	acc_update_device_async_array_h_;
> +	acc_update_self_async;
> +	acc_update_self_async_32_h_;
> +	acc_update_self_async_64_h_;
> +	acc_update_self_async_array_h_;
> +} OACC_2.0;
> +
>  GOACC_2.0 {
>    global:
>  	GOACC_data_end;
> @@ -417,3 +451,8 @@ GOMP_PLUGIN_1.1 {
>    global:
>  	GOMP_PLUGIN_target_task_completion;
>  } GOMP_PLUGIN_1.0;
> +
> +GOMP_PLUGIN_1.2 {
> +  global:
> +	GOMP_PLUGIN_acc_thread_default_async;
> +} GOMP_PLUGIN_1.1;
> 
> 
> Grüße
>  Thomas
>

Hi!

On Tue, 14 Feb 2017 19:58:11 +0800, Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
> On 2017/2/14 07:25 PM, Thomas Schwinge wrote:
> > Testing [...], I saw a lot of regressions,
> > and in r245427 just committed [...] to address
> > these.  Did you simply forget to commit your changes to
> > libgomp/libgomp.map, or why did this work for you?  Please verify:
> 
> Weird, I did not see any regressions

We figured it out; I just filed <https://gcc.gnu.org/PR79543>
'Inappropriate "ld --version" checking'.


Grüße
 Thomas