diff mbox

[1/4] ptp: do not explicitly set drvdata in ptp_clock_register()

Message ID 20170214035108.19622-1-dmitry.torokhov@gmail.com
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Dmitry Torokhov Feb. 14, 2017, 3:51 a.m. UTC
We do not need explicitly call dev_set_drvdata(), as it is done for us by
device_create().

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/ptp/ptp_clock.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Richard Cochran Feb. 14, 2017, 8:30 a.m. UTC | #1
Dmitry,

Be sure to put davem onto CC next time, as he merges any PTP work.

On Mon, Feb 13, 2017 at 07:51:05PM -0800, Dmitry Torokhov wrote:
> We do not need explicitly call dev_set_drvdata(), as it is done for us by
> device_create().

Acked-by: Richard Cochran <richardcochran@gmail.com>
diff mbox

Patch

diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index 9c13381b6966..b4e5e8022c29 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -227,8 +227,6 @@  struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
 	if (IS_ERR(ptp->dev))
 		goto no_device;
 
-	dev_set_drvdata(ptp->dev, ptp);
-
 	err = ptp_populate_sysfs(ptp);
 	if (err)
 		goto no_sysfs;