Patchwork [V7,10/15] configure: Always use 64bits target physical addresses with xen enabled.

login
register
mail settings
Submitter Anthony PERARD
Date Nov. 23, 2010, 7:51 p.m.
Message ID <1290541910-11332-11-git-send-email-anthony.perard@citrix.com>
Download mbox | patch
Permalink /patch/72742/
State New
Headers show

Comments

Anthony PERARD - Nov. 23, 2010, 7:51 p.m.
From: Anthony PERARD <anthony.perard@citrix.com>

With MapCache, we can handle a 64b target, even with a 32b host/qemu.
So, we need to have target_phys_addr_t to 64bits.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 configure |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Alexander Graf - Nov. 29, 2010, 5:59 p.m.
On 23.11.2010, at 20:51, Anthony.Perard@citrix.com wrote:

> From: Anthony PERARD <anthony.perard@citrix.com>
> 
> With MapCache, we can handle a 64b target, even with a 32b host/qemu.
> So, we need to have target_phys_addr_t to 64bits.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> configure |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/configure b/configure
> index 7625054..7688b20 100755
> --- a/configure
> +++ b/configure
> @@ -2950,6 +2950,9 @@ case "$target_arch2" in
>     exit 1
>   ;;
> esac
> +if test "$xen" = yes; then
> +  target_phys_bits=64
> +fi

This makes all targets be 64-bit target_phys when xen mode is enabled for x86 only, right? It should be restricted to x86.

Alex
Anthony PERARD - Nov. 29, 2010, 6:49 p.m.
On Mon, 29 Nov 2010, Alexander Graf wrote:

>
> On 23.11.2010, at 20:51, Anthony.Perard@citrix.com wrote:
>
> > From: Anthony PERARD <anthony.perard@citrix.com>
> >
> > With MapCache, we can handle a 64b target, even with a 32b host/qemu.
> > So, we need to have target_phys_addr_t to 64bits.
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > ---
> > configure |    3 +++
> > 1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 7625054..7688b20 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2950,6 +2950,9 @@ case "$target_arch2" in
> >     exit 1
> >   ;;
> > esac
> > +if test "$xen" = yes; then
> > +  target_phys_bits=64
> > +fi
>
> This makes all targets be 64-bit target_phys when xen mode is enabled for x86 only, right? It should be restricted to x86.

Right, I will restricted to x86 target.

Patch

diff --git a/configure b/configure
index 7625054..7688b20 100755
--- a/configure
+++ b/configure
@@ -2950,6 +2950,9 @@  case "$target_arch2" in
     exit 1
   ;;
 esac
+if test "$xen" = yes; then
+  target_phys_bits=64
+fi
 echo "TARGET_ARCH=$TARGET_ARCH" >> $config_target_mak
 target_arch_name="`echo $TARGET_ARCH | tr '[:lower:]' '[:upper:]'`"
 echo "TARGET_$target_arch_name=y" >> $config_target_mak