+ quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes.patch added to -mm tree
diff mbox

Message ID 200811050133.mA51XdGK018615@imap1.linux-foundation.org
State Not Applicable, archived
Headers show

Commit Message

Andrew Morton Nov. 5, 2008, 1:33 a.m. UTC
The patch titled
     quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes
has been added to the -mm tree.  Its filename is
     quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes
From: Andrew Morton <akpm@linux-foundation.org>

ERROR: code indent should use tabs where possible
#193: FILE: fs/dquot.c:1279:
+         * re-enter the quota code and are already holding the mutex$

ERROR: code indent should use tabs where possible
#194: FILE: fs/dquot.c:1280:
+         */$

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#254: FILE: fs/dquot.c:2352:
+EXPORT_SYMBOL(dquot_reserve_space);

WARNING: line over 80 characters
#274: FILE: include/linux/quota.h:295:
+	int (*reserve_space) (struct inode *, qsize_t, int); /* reserve quota for delayed block allocation */

total: 2 errors, 2 warnings, 244 lines checked

./patches/quota-add-reservation-support-for-delayed-block-allocation.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: <linux-ext4@vger.kernel.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/dquot.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch
diff mbox

diff -puN fs/dquot.c~quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes fs/dquot.c
--- a/fs/dquot.c~quota-add-reservation-support-for-delayed-block-allocation-checkpatch-fixes
+++ a/fs/dquot.c
@@ -1276,8 +1276,8 @@  int dquot_alloc_space(struct inode *inod
 
 	/*
 	 * First test before acquiring mutex - solves deadlocks when we
-         * re-enter the quota code and are already holding the mutex
-         */
+	 * re-enter the quota code and are already holding the mutex
+	 */
 	if (IS_NOQUOTA(inode)) {
 		inode_add_bytes(inode, number);
 		return ret;