From patchwork Mon Feb 13 08:14:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Mc Guire X-Patchwork-Id: 727140 X-Patchwork-Delegate: cyrille.pitchen@atmel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vMJJm73N8z9s7c for ; Mon, 13 Feb 2017 19:15:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b5wHlbVz"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Nwy4/o94Ng7vxjuxNTeVwLczyj2CpkaVJd/WJM9knnw=; b=b5w HlbVznn25W4lZTEdPT6B0K/7xd4XsStPbzl+54ypaDz2DouFICr/krQrpWfln7lXCcokPqlBuwdtB KMJyjIF4kluXS3D1sz48Nq6op8keo869w2tcbNIY6jc0H9s/ULelDVo4kbCszIOhnmZT+cRwZaRqW 0WlJcXAVoJxFQN3gySp71cP0c0SS0sJJ1ExchvzPGpJCTYT2GF+7dHF8ykhHnvM2UBOJYGWTDAFGJ Tc2vIF/5efCErErerJUj+HCN0t+4bosw/4s+fZlwFl+fwQ0A15p2y0WD7UuXwnYvToF76ObxrK1Gu dLJvpBB58sVOnHMXcYSS0ueBCrNIQEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cdBnF-0003Yd-Of; Mon, 13 Feb 2017 08:15:29 +0000 Received: from www.osadl.org ([62.245.132.105]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cdBn6-00023K-2e for linux-mtd@lists.infradead.org; Mon, 13 Feb 2017 08:15:26 +0000 Received: from debian01.hofrr.at (92-243-34-74.adsl.nanet.at [92.243.34.74] (may be forged)) by www.osadl.org (8.13.8/8.13.8/OSADL-2007092901) with ESMTP id v1D8DL45003906; Mon, 13 Feb 2017 09:13:21 +0100 From: Nicholas Mc Guire To: Cyrille Pitchen Subject: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement Date: Mon, 13 Feb 2017 09:14:21 +0100 Message-Id: <1486973661-1164-1-git-send-email-der.herr@hofr.at> X-Mailer: git-send-email 2.1.4 X-Spam-Status: No, score=-0.9 required=6.0 tests=BAYES_00, KHOP_SC_TOP_CIDR8, RDNS_DYNAMIC,SPF_PASS autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on www.osadl.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170213_001520_732155_6A2E9071 X-CRM114-Status: UNSURE ( 6.20 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [62.245.132.105 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , David Woodhouse , linux-kernel@vger.kernel.org, Marek Vasut , linux-mtd@lists.infradead.org, Richard Weinberger , Nicholas Mc Guire , Brian Norris , Mika Westerberg MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This fixes a sparse warning about incorrect type in retrun expression Signed-off-by: Nicholas Mc Guire Acked-by: Marek Vasut Acked-by: Mika Westerberg --- V2: fixed prefix and the truncated commit message noted by Boris Brezillon - thanks! sparse complained about: drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces) drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi * drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] *base Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y) Patch is against 4.10-rc7 (localversion-next is next-20170213) drivers/mtd/spi-nor/intel-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c index 2956f2c..1a6de4b 100644 --- a/drivers/mtd/spi-nor/intel-spi.c +++ b/drivers/mtd/spi-nor/intel-spi.c @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev, ispi->base = devm_ioremap_resource(dev, mem); if (IS_ERR(ispi->base)) - return ispi->base; + return ERR_CAST(ispi->base); ispi->dev = dev; ispi->info = info;