diff mbox

e2fsprogs: remove duplicate default values in mke2fs.conf

Message ID 20170211151535.3242-1-xose.vazquez@gmail.com
State Rejected, archived
Headers show

Commit Message

Xose Vazquez Perez Feb. 11, 2017, 3:15 p.m. UTC
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: EXT4 ml <linux-ext4@vger.kernel.org>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 misc/mke2fs.conf.in | 3 ---
 1 file changed, 3 deletions(-)

Comments

Theodore Ts'o Feb. 16, 2017, 4:28 p.m. UTC | #1
On Sat, Feb 11, 2017 at 04:15:35PM +0100, Xose Vazquez Perez wrote:
> @@ -12,11 +12,9 @@
>  	}
>  	ext4 = {
>  		features = has_journal,extent,huge_file,flex_bg,uninit_bg,64bit,dir_nlink,extra_isize
> -		inode_size = 256
>  	}
>  	ext4dev = {
>  		features = has_journal,extent,huge_file,flex_bg,uninit_bg,inline_data,64bit,dir_nlink,extra_isize
> -		inode_size = 256
>  		options = test_fs=1
>  	}
>  	small = {

These are duplicate values (although they don't do any harm).

> @@ -47,6 +45,5 @@
>  		blocksize = -1
>  	}
>  	hurd = {
> -	     blocksize = 4096
>  	     inode_size = 128
>  	}

This value *is* required.  The Hurd has a re-implementation of the
ext2/3/4 file system, which is very limited.  One of its limitations
is the block size must be equal to the page size (and it only works on
x86.)   So the "blocksize = 4096" is required so that:

	mke2fs -o hurd /tmp/foo.img 1024

will use a 4k block size even for small file systems.

     	      	    	      - Ted
diff mbox

Patch

diff --git a/misc/mke2fs.conf.in b/misc/mke2fs.conf.in
index 812f7c74..3d612594 100644
--- a/misc/mke2fs.conf.in
+++ b/misc/mke2fs.conf.in
@@ -12,11 +12,9 @@ 
 	}
 	ext4 = {
 		features = has_journal,extent,huge_file,flex_bg,uninit_bg,64bit,dir_nlink,extra_isize
-		inode_size = 256
 	}
 	ext4dev = {
 		features = has_journal,extent,huge_file,flex_bg,uninit_bg,inline_data,64bit,dir_nlink,extra_isize
-		inode_size = 256
 		options = test_fs=1
 	}
 	small = {
@@ -47,6 +45,5 @@ 
 		blocksize = -1
 	}
 	hurd = {
-	     blocksize = 4096
 	     inode_size = 128
 	}