diff mbox

[v2] powerpc/pseries: Fix missing of_node_put

Message ID 20170210194505.8236-1-christophe.jaillet@wanadoo.fr (mailing list archive)
State Rejected
Headers show

Commit Message

Christophe JAILLET Feb. 10, 2017, 7:45 p.m. UTC 
If 'dlpar_configure_connector()' fails, 'parent_dn' should be released.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
v2: Reorder code in order to simplify the proposed patch
---
 arch/powerpc/platforms/pseries/mobility.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index 5a0c7ba429ce..2f8be51f5fd0 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -226,6 +226,7 @@  static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
 		return -ENOENT;
 
 	dn = dlpar_configure_connector(drc_index, parent_dn);
+	of_node_put(parent_dn);
 	if (!dn)
 		return -ENOENT;
 
@@ -233,7 +234,6 @@  static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
 	if (rc)
 		dlpar_free_cc_nodes(dn);
 
-	of_node_put(parent_dn);
 	return rc;
 }