diff mbox

Move more csin, csinh tests to auto-libm-test-in [committed]

Message ID alpine.DEB.2.20.1702091831160.8971@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Feb. 9, 2017, 6:31 p.m. UTC 
When I moved tests of csin and csinh to auto-libm-test-in, I didn't
move a few tests for which gen-auto-libm-tests was very slow because
of MPC slowness on certain inputs.

Now that auto-libm-test-out has been split up, such slowness only
affects regenerating the test expectations for the individual
functions in question, rather than any addition of tests for any
function to auto-libm-test-in.  Thus, I no longer consider it a
problem to have these inputs in auto-libm-test-in, and this patch
moves them there.  This results in test generation for csin and csinh
taking 5m43s (for each of csin and csinh) on my system, while other
functions are unaffected.

I expect the test generation to be much faster in MPC 1.1 (the
relevant performance improvements went in MPC mainline in Dec 2013,
but there hasn't been a release from mainline since then).

Tested for x86_64 and x86.  Committed.

(Generated file diffs omitted below.)

2017-02-09  Joseph Myers  <joseph@codesourcery.com>

	* math/auto-libm-test-in: Add more tests of csin and csinh.
	* math/auto-libm-test-out-csin: Regenerated.
	* math/auto-libm-test-out-csinh: Likewise.
	* math/libm-test-csin.inc (csin_test_data): Remove tests moved to
	auto-libm-test-in.
	* math/libm-test-csinh.inc (csinh_test_data): Likewise.
diff mbox

Patch

diff --git a/math/auto-libm-test-in b/math/auto-libm-test-in
index 58236ef..64d1784 100644
--- a/math/auto-libm-test-in
+++ b/math/auto-libm-test-in
@@ -1253,6 +1253,9 @@  csin -min 1
 csin min_subnorm 80
 csin -min_subnorm 80
 
+csin min_subnorm min
+csin min min_subnorm
+
 csinh 0.0 0.0
 csinh -0 0.0
 csinh 0.0 -0
@@ -1288,6 +1291,9 @@  csinh 1 -min
 csinh 80 min_subnorm
 csinh 80 -min_subnorm
 
+csinh min_subnorm min
+csinh min min_subnorm
+
 csqrt 0 0
 csqrt 0 -0
 csqrt -0 0
diff --git a/math/libm-test-csin.inc b/math/libm-test-csin.inc
index 3bf5eeb..f42828c 100644
--- a/math/libm-test-csin.inc
+++ b/math/libm-test-csin.inc
@@ -64,9 +64,6 @@  static const struct test_c_c_data csin_test_data[] =
     TEST_c_c (csin, qnan_value, qnan_value, qnan_value, qnan_value),
 
     AUTO_TESTS_c_c (csin),
-
-    TEST_c_c (csin, min_subnorm_value, min_value, min_subnorm_value, min_value, UNDERFLOW_EXCEPTION),
-    TEST_c_c (csin, min_value, min_subnorm_value, min_value, min_subnorm_value, UNDERFLOW_EXCEPTION),
   };
 
 static void
diff --git a/math/libm-test-csinh.inc b/math/libm-test-csinh.inc
index 5c4c687..06877c8 100644
--- a/math/libm-test-csinh.inc
+++ b/math/libm-test-csinh.inc
@@ -64,9 +64,6 @@  static const struct test_c_c_data csinh_test_data[] =
     TEST_c_c (csinh, qnan_value, qnan_value, qnan_value, qnan_value),
 
     AUTO_TESTS_c_c (csinh),
-
-    TEST_c_c (csinh, min_subnorm_value, min_value, min_subnorm_value, min_value, UNDERFLOW_EXCEPTION),
-    TEST_c_c (csinh, min_value, min_subnorm_value, min_value, min_subnorm_value, UNDERFLOW_EXCEPTION),
   };
 
 static void