Patchwork [7/7] tcg-ia64: Fix warning in qemu_ld.

login
register
mail settings
Submitter Richard Henderson
Date Nov. 22, 2010, 10:57 p.m.
Message ID <1290466678-6337-8-git-send-email-rth@twiddle.net>
Download mbox | patch
Permalink /patch/72614/
State New
Headers show

Comments

Richard Henderson - Nov. 22, 2010, 10:57 p.m.
The usermode version of qemu_ld doesn't used mem_index,
leading to set-but-not-used warnings.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/ia64/tcg-target.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
malc - Nov. 23, 2010, 9:09 a.m.
On Mon, 22 Nov 2010, Richard Henderson wrote:

> The usermode version of qemu_ld doesn't used mem_index,

"doesn't used"? Doesn't use perhaps?

> leading to set-but-not-used warnings.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/ia64/tcg-target.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
> index 57d0bcc..3ddf434 100644
> --- a/tcg/ia64/tcg-target.c
> +++ b/tcg/ia64/tcg-target.c
> @@ -1658,11 +1658,10 @@ static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
>      static uint64_t const opc_sxt_i29[4] = {
>          OPC_SXT1_I29, OPC_SXT2_I29, OPC_SXT4_I29, 0
>      };
> -    int addr_reg, data_reg, mem_index, s_bits, bswap;
> +    int addr_reg, data_reg, s_bits, bswap;
>  
>      data_reg = *args++;
>      addr_reg = *args++;
> -    mem_index = *args;
>      s_bits = opc & 3;
>  
>  #ifdef TARGET_WORDS_BIGENDIAN
>
Richard Henderson - Nov. 23, 2010, 3:18 p.m.
On 11/23/2010 01:09 AM, malc wrote:
> On Mon, 22 Nov 2010, Richard Henderson wrote:
> 
>> The usermode version of qemu_ld doesn't used mem_index,
> 
> "doesn't used"? Doesn't use perhaps?

Err, yes, of course.


r~

Patch

diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 57d0bcc..3ddf434 100644
--- a/tcg/ia64/tcg-target.c
+++ b/tcg/ia64/tcg-target.c
@@ -1658,11 +1658,10 @@  static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc)
     static uint64_t const opc_sxt_i29[4] = {
         OPC_SXT1_I29, OPC_SXT2_I29, OPC_SXT4_I29, 0
     };
-    int addr_reg, data_reg, mem_index, s_bits, bswap;
+    int addr_reg, data_reg, s_bits, bswap;
 
     data_reg = *args++;
     addr_reg = *args++;
-    mem_index = *args;
     s_bits = opc & 3;
 
 #ifdef TARGET_WORDS_BIGENDIAN