| Message ID | 1486576658-29719-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
Thomas Huth <thuth@redhat.com> writes: > The "qemu,register" device needs to be wired up in source code, there > is no way the user can make any real use of this device with the > "-device" parameter or the "device_add" monitor command yet. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com>
On Wed, Feb 8, 2017 at 11:27 PM, Markus Armbruster <armbru@redhat.com> wrote: > Thomas Huth <thuth@redhat.com> writes: > >> The "qemu,register" device needs to be wired up in source code, there >> is no way the user can make any real use of this device with the >> "-device" parameter or the "device_add" monitor command yet. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> > > Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com> Thanks, Alistair >
08.02.2017 20:57, Thomas Huth wrote: > The "qemu,register" device needs to be wired up in source code, there > is no way the user can make any real use of this device with the > "-device" parameter or the "device_add" monitor command yet. Applied both v3 patches to -trivial, thank you! /mjt
diff --git a/hw/core/register.c b/hw/core/register.c index 4bfbc50..be170dc 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -274,9 +274,18 @@ void register_finalize_block(RegisterInfoArray *r_array) g_free(r_array); } +static void register_class_init(ObjectClass *oc, void *data) +{ + DeviceClass *dc = DEVICE_CLASS(oc); + + /* Reason: needs to be wired up to work */ + dc->cannot_instantiate_with_device_add_yet = true; +} + static const TypeInfo register_info = { .name = TYPE_REGISTER, .parent = TYPE_DEVICE, + .class_init = register_class_init, }; static void register_register_types(void)
The "qemu,register" device needs to be wired up in source code, there is no way the user can make any real use of this device with the "-device" parameter or the "device_add" monitor command yet. Signed-off-by: Thomas Huth <thuth@redhat.com> --- v3: Another update to the patch description and comment hw/core/register.c | 9 +++++++++ 1 file changed, 9 insertions(+)