@@ -1061,10 +1061,12 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
if (nl_type >= 0)
flower_print_port(f, "src_port", tb[nl_type]);
- nl_type = flower_icmp_attr_type(eth_type, ip_proto, false);
+ nl_type = flower_icmp_attr_type(eth_type, ip_proto,
+ FLOWER_ICMP_FIELD_TYPE);
if (nl_type >= 0)
flower_print_icmp(f, "icmp_type", tb[nl_type]);
- nl_type = flower_icmp_attr_type(eth_type, ip_proto, true);
+ nl_type = flower_icmp_attr_type(eth_type, ip_proto,
+ FLOWER_ICMP_FIELD_CODE);
if (nl_type >= 0)
flower_print_icmp(f, "icmp_code", tb[nl_type]);
Use enum flower_icmp_field rather than bool as type of third parameter when calling flower_icmp_attr_type. Fixes: eb3b5696f163 ("tc: flower: support matching on ICMP type and code") Signed-off-by: Simon Horman <simon.horman@netronome.com> --- * Reposted after breaking out of a larger patch-set * This should not have a run-time affect assuming both false and FLOWER_ICMP_FIELD_TYPE - the first value of enum flower_icmp_field - are zero. --- tc/f_flower.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)