Message ID | 20170207221524.22394-9-stephen@that.guru |
---|---|
State | Superseded |
Headers | show |
Hi Stephen, > + <div class="btn-group pull-right"> I've just applied this - I'm not convinced about the 'pull-right': - Potentially more mouse travel required. - familiarity; I know where to look in the old system Neither are very strong objections but I'd like to know if you've throught about them and had a reason for moving it. Apart from that I like it. (Now if only we had a nice big user base we could do A/B testing on!) Regards, Daniel > + <a href="{% url 'patch-raw' patch_id=submission.id %}" > + class="btn btn-default" role="button" data-toggle="tooltip" > + title="Download patch diff">diff</a> > + <a href="{% url 'patch-mbox' patch_id=submission.id %}" > + class="btn btn-default" role="button" data-toggle="tooltip" > + title="Download patch mbox">mbox</a> > + </div> > </h2> > + > <div id="patch" class="patch"> > <pre class="content"> > {{ submission|patchsyntax }} > -- > 2.9.3 > > _______________________________________________ > Patchwork mailing list > Patchwork@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/patchwork
On Fri, 2017-02-24 at 14:47 +1100, Daniel Axtens wrote: > Hi Stephen, > > > + <div class="btn-group pull-right"> > > I've just applied this - I'm not convinced about the 'pull-right': > - Potentially more mouse travel required. > - familiarity; I know where to look in the old system > > Neither are very strong objections but I'd like to know if you've > throught about them and had a reason for moving it. The main reason I move them across is that they look odd beside the heading due to the height differences. I figured this was a common enough convention and "power users" would be using something like 'pwclient' anyway. Perhaps you could try removing the pull-right locally and let me know if you think it's acceptable? > Apart from that I like it. > > (Now if only we had a nice big user base we could do A/B testing on!) Aye - I'm trying to guess what users would be happy with, rather than validating it. Not much I can do about that though :) Stephen
diff --git a/patchwork/templates/patchwork/submission.html b/patchwork/templates/patchwork/submission.html index 21c345f..66c1159 100644 --- a/patchwork/templates/patchwork/submission.html +++ b/patchwork/templates/patchwork/submission.html @@ -281,14 +281,16 @@ function toggle_div(link_id, headers_id) {% if submission.diff %} <h2> Patch - <a href="javascript:toggle_div('hide-patch', 'patch')" id="hide-patch">hide</a></span> - <span>|</span> - <a href="{% url 'patch-raw' patch_id=submission.id %}" - >download patch</a> - <span>|</span> - <a href="{% url 'patch-mbox' patch_id=submission.id %}" - >download mbox</a> + <div class="btn-group pull-right"> + <a href="{% url 'patch-raw' patch_id=submission.id %}" + class="btn btn-default" role="button" data-toggle="tooltip" + title="Download patch diff">diff</a> + <a href="{% url 'patch-mbox' patch_id=submission.id %}" + class="btn btn-default" role="button" data-toggle="tooltip" + title="Download patch mbox">mbox</a> + </div> </h2> + <div id="patch" class="patch"> <pre class="content"> {{ submission|patchsyntax }}
We'll make use of this to enable downloading of patches with mboxes. In addition, the 'hide' link for patches and cover letters is removed. There's no way to enable this by default and the use cases are dubious at best. Signed-off-by: Stephen Finucane <stephen@that.guru> --- patchwork/templates/patchwork/submission.html | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)