diff mbox

[20/28] tests: fix virtio-scsi-test leak

Message ID 20170207135211.15870-21-marcandre.lureau@redhat.com
State New
Headers show

Commit Message

Marc-André Lureau Feb. 7, 2017, 1:52 p.m. UTC 
Spotted by ASAN.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/virtio-scsi-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg Kurz Feb. 7, 2017, 4:43 p.m. UTC | #1 
On Tue,  7 Feb 2017 17:52:03 +0400
Marc-André Lureau <marcandre.lureau@redhat.com> wrote:

> Spotted by ASAN.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

>  tests/virtio-scsi-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
> index 69220ef07b..0eabd56fd9 100644
> --- a/tests/virtio-scsi-test.c
> +++ b/tests/virtio-scsi-test.c
> @@ -63,7 +63,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
>          qvirtqueue_cleanup(vs->dev->bus, vs->vq[i], vs->qs->alloc);
>      }
>      qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev));
> -    g_free(vs->dev);
> +    qvirtio_pci_device_free((QVirtioPCIDevice *)vs->dev);
>      qvirtio_scsi_stop(vs->qs);
>      g_free(vs);
>  }
diff mbox

Patch

diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
index 69220ef07b..0eabd56fd9 100644
--- a/tests/virtio-scsi-test.c
+++ b/tests/virtio-scsi-test.c
@@ -63,7 +63,7 @@  static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
         qvirtqueue_cleanup(vs->dev->bus, vs->vq[i], vs->qs->alloc);
     }
     qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev));
-    g_free(vs->dev);
+    qvirtio_pci_device_free((QVirtioPCIDevice *)vs->dev);
     qvirtio_scsi_stop(vs->qs);
     g_free(vs);
 }