[tpmdd-devel] tpm xen: drop unneeded chip variable

Submitted by Julia Lawall on Feb. 5, 2017, 9:39 p.m.

Details

Message ID 1486330777-11341-1-git-send-email-Julia.Lawall@lip6.fr
State New
Headers show

Commit Message

Julia Lawall Feb. 5, 2017, 9:39 p.m.
The call that used chip was dropped in 1f0f30e404b3.  Drop the
leftover declaration and initialization.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/char/tpm/xen-tpmfront.c |    2 --
 1 file changed, 2 deletions(-)



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

Comments

Jarkko Sakkinen Feb. 8, 2017, 1:02 p.m.
On Sun, Feb 05, 2017 at 10:39:37PM +0100, Julia Lawall wrote:
> The call that used chip was dropped in 1f0f30e404b3.  Drop the
> leftover declaration and initialization.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

> 
> ---
>  drivers/char/tpm/xen-tpmfront.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
> index 5aaa268..656e8af 100644
> --- a/drivers/char/tpm/xen-tpmfront.c
> +++ b/drivers/char/tpm/xen-tpmfront.c
> @@ -289,7 +289,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>  		const struct xenbus_device_id *id)
>  {
>  	struct tpm_private *priv;
> -	struct tpm_chip *chip;
>  	int rv;
>  
>  	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
> @@ -306,7 +305,6 @@ static int tpmfront_probe(struct xenbus_device *dev,
>  
>  	rv = setup_ring(dev, priv);
>  	if (rv) {
> -		chip = dev_get_drvdata(&dev->dev);
>  		ring_free(priv);
>  		return rv;
>  	}
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

Patch hide | download patch | download mbox

diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c
index 5aaa268..656e8af 100644
--- a/drivers/char/tpm/xen-tpmfront.c
+++ b/drivers/char/tpm/xen-tpmfront.c
@@ -289,7 +289,6 @@  static int tpmfront_probe(struct xenbus_device *dev,
 		const struct xenbus_device_id *id)
 {
 	struct tpm_private *priv;
-	struct tpm_chip *chip;
 	int rv;
 
 	priv = kzalloc(sizeof(*priv), GFP_KERNEL);
@@ -306,7 +305,6 @@  static int tpmfront_probe(struct xenbus_device *dev,
 
 	rv = setup_ring(dev, priv);
 	if (rv) {
-		chip = dev_get_drvdata(&dev->dev);
 		ring_free(priv);
 		return rv;
 	}