| Message ID | d0a433aa6bbe20dfe4fd4f3ca9aec50f97601403.1290305776.git.joe@perches.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
| From: Joe Perches <joe@perches.com>
| Date: Saturday, November 20, 2010 06:38 pm
|
| Using static const generally increases object text and decreases data size.
| It also generally decreases overall object size.
|
| text data bss dec hex filename
| 10179 56 2216 12451 30a3 drivers/net/cxgb4vf/t4vf_hw.o.new
| 10179 56 2216 12451 30a3 drivers/net/cxgb4vf/t4vf_hw.o.old
|
| Signed-off-by: Joe Perches <joe@perches.com>
| ---
| drivers/net/cxgb4vf/t4vf_hw.c | 2 +-
| 1 files changed, 1 insertions(+), 1 deletions(-)
|
| diff --git a/drivers/net/cxgb4vf/t4vf_hw.c b/drivers/net/cxgb4vf/t4vf_hw.c
| index f7d7f97..daedf6e 100644
| --- a/drivers/net/cxgb4vf/t4vf_hw.c
| +++ b/drivers/net/cxgb4vf/t4vf_hw.c
| @@ -116,7 +116,7 @@ static void dump_mbox(struct adapter *adapter, const
| char *tag, u32 mbox_data) int t4vf_wr_mbox_core(struct adapter *adapter,
| const void *cmd, int size, void *rpl, bool sleep_ok)
| {
| - static int delay[] = {
| + static const int delay[] = {
| 1, 1, 3, 5, 10, 10, 20, 50, 100
| };
Looks okay to me. Thanks!
Casey
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/cxgb4vf/t4vf_hw.c b/drivers/net/cxgb4vf/t4vf_hw.c index f7d7f97..daedf6e 100644 --- a/drivers/net/cxgb4vf/t4vf_hw.c +++ b/drivers/net/cxgb4vf/t4vf_hw.c @@ -116,7 +116,7 @@ static void dump_mbox(struct adapter *adapter, const char *tag, u32 mbox_data) int t4vf_wr_mbox_core(struct adapter *adapter, const void *cmd, int size, void *rpl, bool sleep_ok) { - static int delay[] = { + static const int delay[] = { 1, 1, 3, 5, 10, 10, 20, 50, 100 };
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. text data bss dec hex filename 10179 56 2216 12451 30a3 drivers/net/cxgb4vf/t4vf_hw.o.new 10179 56 2216 12451 30a3 drivers/net/cxgb4vf/t4vf_hw.o.old Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/cxgb4vf/t4vf_hw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)