From patchwork Sun Feb 5 10:00:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Ulli Kroll X-Patchwork-Id: 724216 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vGR1t6yjMz9s7f for ; Sun, 5 Feb 2017 21:00:50 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=googlemail.com header.i=@googlemail.com header.b="QXI3/l+D"; dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 35361B912EE; Sun, 5 Feb 2017 11:00:46 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP; Sun, 5 Feb 2017 11:00:46 +0100 (CET) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 4DAB1B800BB for ; Sun, 5 Feb 2017 11:00:45 +0100 (CET) X-policyd-weight: using cached result; rate: -7 Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Sun, 5 Feb 2017 11:00:45 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id r18so14991544wmd.3 for ; Sun, 05 Feb 2017 02:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=dXm/3r/DcLAsVW2ZornIT+pGpL7r8jcxafjbeVigStA=; b=QXI3/l+DrXdUIXWtOvXNFGJesiuDI90WVQIeDIC/+Jq7F/d5xw68Vn4FLVPKbuahoR e6YZPSBml8ThhlutSIaBsvKX7v50SEkESkIfArheiDEFhYUi6uCIsxicLe82G6HUQLgi xO//URuOG7Lvw94kN/YrwQllDsNrfnZbVCS5t29oLuC1eFt5aCEbijIBZyMyeteAPTDj s5u0fWoOajrIClgxVEAcjNO7LqxV/lFlKpFt/+Vi2Mdn6Cm0oC+XbqAalzWX19hhKj5t yWifxMT3vL6hcn7Y7AEVYSWxB/4O/u9PkX19gs+hf1iOiSwN9KNnu0iawRuOcYRHQnRF 7flg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=dXm/3r/DcLAsVW2ZornIT+pGpL7r8jcxafjbeVigStA=; b=NMIPBg90spRJRt7a01QRTNj9oe/tHilpf8jyLiABSQsyw/9U6FA7N9Vzjp8sw8v4uf EJ/fpjlUQEUit4AjuDtTkXNXrP3Mo1ojfxKpjHdtZvyv+UvmeAjB/f3DYg72Soe+YEmo Um0yfJ9EflFXTRMB7yrejg/+OwZ6MmC1jZJGDUpthQRlh67c4+GgUkvcWC6DL+rPjhmz C8os7oTiPCcpSbRbY2LHr9u/2lrgqw0mOcFUfJa7c4E0KsN4iEXPDXsX/tGYSDBFuUI+ NiaKFdkxLNCMNYHyxSg3FbavaLD+PmVRYUEq1eUGM6Q3LidTG7iSuQUJ7R0kq2yaLwIp h8SQ== X-Gm-Message-State: AIkVDXIx0Tftx2KVQN54Gk8ezTYphAgVw+oa6GW5ZiW6hbrmwv+bYXyTcxI4Qbeo60hobg== X-Received: by 10.223.146.196 with SMTP id 62mr4603118wrn.199.1486288844672; Sun, 05 Feb 2017 02:00:44 -0800 (PST) Received: from localhost (cable-78-34-25-212.netcologne.de. [78.34.25.212]) by smtp.gmail.com with ESMTPSA id z134sm6652362wmc.20.2017.02.05.02.00.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Feb 2017 02:00:44 -0800 (PST) Date: Sun, 5 Feb 2017 11:00:41 +0100 (CET) From: Hans Ulli Kroll X-X-Sender: elektroman@T420s To: Linus Walleij In-Reply-To: <20170128204839.18330-2-linus.walleij@linaro.org> Message-ID: References: <20170128204839.18330-1-linus.walleij@linaro.org> <20170128204839.18330-2-linus.walleij@linaro.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Subject: Re: [OpenWrt-Devel] [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openwrt-devel@openwrt.org, Paulius Zaleckas , linux-pci@vger.kernel.org, Bjorn Helgaas , Janos Laube , linux-arm-kernel@lists.infradead.org Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" Hi Linus while debugging my boot issues on my NAS 4220, I saw this warning irq: type mismatch, failed to map hwirq-26 for /soc/interrupt-controller@48000000! We need to use the use the use the PCI IRQ from gemini as root for the irq domain, not the next one in DT. diff --git a/drivers/pci/host/pci-gemini.c b/drivers/pci/host/pci-gemini.c index 7051dd992114..bb564a8e6379 100644 --- a/drivers/pci/host/pci-gemini.c +++ b/drivers/pci/host/pci-gemini.c @@ -217,7 +217,6 @@ static const struct irq_domain_ops gemini_pci_irqdomain_ops = { static int gemini_pci_setup_irq(struct gemini_pci *p, int irq) { - struct device_node *intc = of_get_next_child(p->dev->of_node, NULL); int i; if (!intc) { @@ -225,7 +224,7 @@ static int gemini_pci_setup_irq(struct gemini_pci *p, int irq) return -EINVAL; } - p->irqdomain = irq_domain_add_linear(intc, 4, + p->irqdomain = irq_domain_add_linear(p->dev->of_node, 4, &gemini_pci_irqdomain_ops, p); if (!p->irqdomain) {