diff mbox

[1/1] package/unixodbc: add optional dependency to libtool

Message ID 20170204164327.10478-1-bernd.kuhls@t-online.de
State Accepted
Headers show

Commit Message

Bernd Kuhls Feb. 4, 2017, 4:43 p.m. UTC
To get reproducable builds of unixodbc add libtool as optional
dependency.

Without libtool:

$ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]

With libtool:

$ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libltdl.so.7]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/unixodbc/unixodbc.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Thomas Petazzoni Feb. 4, 2017, 10:55 p.m. UTC | #1
Hello,

On Sat,  4 Feb 2017 17:43:27 +0100, Bernd Kuhls wrote:
> To get reproducable builds of unixodbc add libtool as optional
> dependency.
> 
> Without libtool:
> 
> $ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]
> 
> With libtool:
> 
> $ host/usr/bin/x86_64-linux-readelf -a target/usr/lib/libodbc.so.2.0.0 | grep NEEDED
>  0x0000000000000001 (NEEDED)             Shared library: [libltdl.so.7]
>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.0]
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/unixodbc/unixodbc.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas
diff mbox

Patch

diff --git a/package/unixodbc/unixodbc.mk b/package/unixodbc/unixodbc.mk
index f66daab4a..280fe5791 100644
--- a/package/unixodbc/unixodbc.mk
+++ b/package/unixodbc/unixodbc.mk
@@ -20,6 +20,13 @@  else
 UNIXODBC_CONF_OPTS += --disable-iconv
 endif
 
+ifeq ($(BR2_PACKAGE_LIBTOOL),y)
+UNIXODBC_CONF_OPTS += --without-included-ltdl
+UNIXODBC_DEPENDENCIES += libtool
+else
+UNIXODBC_CONF_OPTS += --with-included-ltdl
+endif
+
 ifeq ($(BR2_PACKAGE_READLINE),y)
 UNIXODBC_CONF_OPTS += --enable-readline
 UNIXODBC_DEPENDENCIES += readline