| Message ID | 76d2bd45fbde30f47992b99cf5014dbab4079882.1290305776.git.joe@perches.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 21314e0..31dc45a 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -1082,7 +1082,9 @@ static int vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq, struct vmxnet3_adapter *adapter, int quota) { - static u32 rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; + static const u32 rxprod_reg[2] = { + VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2 + }; u32 num_rxd = 0; struct Vmxnet3_RxCompDesc *rcd; struct vmxnet3_rx_ctx *ctx = &rq->rx_ctx;
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. text data bss dec hex filename 38916 437 9160 48513 bd81 drivers/net/vmxnet3/vmxnet3_drv.o.new 38916 437 9160 48513 bd81 drivers/net/vmxnet3/vmxnet3_drv.o.old Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)