Message ID | 1e63ae86560183cec72aa188fc18d84411acdc70.1290305775.git.joe@perches.com |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
diff --git a/drivers/net/3c507.c b/drivers/net/3c507.c index 475a66d..1e94555 100644 --- a/drivers/net/3c507.c +++ b/drivers/net/3c507.c @@ -311,8 +311,8 @@ static int mem_start; struct net_device * __init el16_probe(int unit) { struct net_device *dev = alloc_etherdev(sizeof(struct net_local)); - static unsigned ports[] = { 0x300, 0x320, 0x340, 0x280, 0}; - unsigned *port; + static const unsigned ports[] = { 0x300, 0x320, 0x340, 0x280, 0}; + const unsigned *port; int err = -ENODEV; if (!dev)
Using static const generally increases object text and decreases data size. It also generally decreases overall object size. text data bss dec hex filename 10001 400 2168 12569 3119 drivers/net/3c507.o.new 9981 420 2168 12569 3119 drivers/net/3c507.o.old Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/3c507.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)