From patchwork Fri Nov 19 19:30:16 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Grosser X-Patchwork-Id: 72301 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6D1DE1007D2 for ; Sat, 20 Nov 2010 06:30:15 +1100 (EST) Received: (qmail 30630 invoked by alias); 19 Nov 2010 19:30:11 -0000 Received: (qmail 30598 invoked by uid 22791); 19 Nov 2010 19:30:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, TW_CX X-Spam-Check-By: sourceware.org Received: from out1.smtp.messagingengine.com (HELO out1.smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Nov 2010 19:30:02 +0000 Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.messagingengine.com (Postfix) with ESMTP id 4A2B3596; Fri, 19 Nov 2010 14:30:01 -0500 (EST) Received: from frontend1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 19 Nov 2010 14:30:01 -0500 Received: from [128.146.27.114] (dhcp-128-146-27-114.osuwireless.ohio-state.edu [128.146.27.114]) by mail.messagingengine.com (Postfix) with ESMTPSA id A1C7C402324; Fri, 19 Nov 2010 14:30:00 -0500 (EST) Message-ID: <4CE6D048.2040208@fim.uni-passau.de> Date: Fri, 19 Nov 2010 14:30:16 -0500 From: Tobias Grosser User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9pre) Gecko/20100802 Lightning/1.0b2 Lanikai/3.1.2pre MIME-Version: 1.0 To: Andreas Schwab CC: Paolo Bonzini , Sven Verdoolaege , Jack Howarth , "Joseph S. Myers" , Sebastian Pop , =?ISO-8859-1?Q?Andreas_Simb=FCrger?= , gcc-patches@gcc.gnu.org, gcc-graphite@googlegroups.com Subject: Re: [PATCH] Support official CLooG.org versions. References: <1289505716-9480-1-git-send-email-simbuerg@googlemail.com> <4CDC542E.2090807@gnu.org> <20101111234103.GA21682@bromo.med.uc.edu> <20101112015320.GA22316@bromo.med.uc.edu> <20101112040945.GA23026@bromo.med.uc.edu> <4CDCFA18.4040604@gnu.org> <20101112084306.GO4255MdfPADPa@purples> <4CDD0201.5050302@gnu.org> <20101112090859.GP4255MdfPADPa@purples> <4CDD0493.2000809@gnu.org> <4CDD67EE.6070807@fim.uni-passau.de> <4CDD740C.1080105@gnu.org> <4CDDA07E.4080206@fim.uni-passau.de> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 11/15/2010 10:54 AM, Andreas Schwab wrote: > Tobias Grosser writes: > >> diff --git a/config/cloog.m4 b/config/cloog.m4 >> index 6ed0f1b..4936e8a 100644 >> --- a/config/cloog.m4 >> +++ b/config/cloog.m4 >> @@ -36,7 +36,19 @@ AC_DEFUN([CLOOG_INIT_FLAGS], >> [AS_HELP_STRING( >> [--with-cloog-lib=PATH], >> [Specify the directory for the installed CLooG library])]) >> - >> + >> + AC_ARG_ENABLE(cloog-backend, >> + [ --enable-cloog-backend[=backend] >> + isl: The cloog.org isl backend >> + ppl-legacy: The legacy ppl backend - default >> + ppl: The cloog.org ppl backend], > > The help string should explain what the option does, referring to the > option argument (which should be written in upper case). Andreas, I propose the attached patch to address your comments. * config/cloog.m4: Use AS_HELP_STRING and fix description. OK to commit? Tobi From be959d16334626e12238e6e3119635b48cc6b087 Mon Sep 17 00:00:00 2001 From: Tobias Grosser Date: Fri, 19 Nov 2010 14:27:31 -0500 Subject: [PATCH] config/cloog.m4: Use AS_HELP_STRING and fix description --- config/cloog.m4 | 8 ++++---- configure | 5 ++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/config/cloog.m4 b/config/cloog.m4 index 96ebd4d..2a846cf 100644 --- a/config/cloog.m4 +++ b/config/cloog.m4 @@ -38,10 +38,10 @@ AC_DEFUN([CLOOG_INIT_FLAGS], [Specify the directory for the installed CLooG library])]) AC_ARG_ENABLE(cloog-backend, - [ --enable-cloog-backend[=backend] - isl: The cloog.org isl backend - ppl-legacy: The legacy ppl backend - default - ppl: The cloog.org ppl backend], + [AS_HELP_STRING( + [--enable-cloog-backend[=backend]], + [Set the CLooG backend used to either ISL, PPL or PPL-LEGACY. + If not specified PPL-LEGACY is selected.])], [ if test "x${enableval}" = "xisl"; then cloog_backend=isl elif test "x${enableval}" = "xppl"; then diff --git a/configure b/configure index b1235c2..1d1993d 100755 --- a/configure +++ b/configure @@ -1453,9 +1453,8 @@ Optional Features: --enable-build-with-cxx build with C++ compiler instead of C compiler --disable-ppl-version-check disable check for PPL version --enable-cloog-backend=backend - isl: The cloog.org isl backend - ppl-legacy: The legacy ppl backend - default - ppl: The cloog.org ppl backend + Set the CLooG backend used to either ISL, PPL or + PPL-LEGACY. If not specified PPL-LEGACY is selected. --disable-cloog-version-check disable check for CLooG version --enable-lto enable link time optimization support -- 1.7.1