diff mbox

net: stmmac: add separate warning for PTP not being supported by HW

Message ID 0983485b-418d-5c9b-e94b-8f4edc9f13cf@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Heiner Kallweit Feb. 1, 2017, 9:02 p.m. UTC
Chips like Amlogic S905GXBB are supported by this driver but don't
have support for PTP. Add a separate warning for missing HW support
to differentiate it from other actual failures.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

David Miller Feb. 3, 2017, 3:01 a.m. UTC | #1
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 1 Feb 2017 22:02:02 +0100

> Chips like Amlogic S905GXBB are supported by this driver but don't
> have support for PTP. Add a separate warning for missing HW support
> to differentiate it from other actual failures.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied to net-netxt.
diff mbox

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 26a2185f..bd83bf9e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1726,8 +1726,10 @@  static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)
 
 	if (init_ptp) {
 		ret = stmmac_init_ptp(priv);
-		if (ret)
-			netdev_warn(priv->dev, "fail to init PTP.\n");
+		if (ret == -EOPNOTSUPP)
+			netdev_warn(priv->dev, "PTP not supported by HW\n");
+		else if (ret)
+			netdev_warn(priv->dev, "PTP init failed\n");
 	}
 
 #ifdef CONFIG_DEBUG_FS