Patchwork Fwd: Dell PowerEdge R410 ICH10 SATA support in Ubuntu Hardy

login
register
mail settings
Submitter Tim Gardner
Date Nov. 19, 2010, 4:29 p.m.
Message ID <4CE6A5DD.9080809@canonical.com>
Download mbox | patch
Permalink /patch/72267/
State Rejected
Delegated to: Tim Gardner
Headers show

Comments

Tim Gardner - Nov. 19, 2010, 4:29 p.m.
On 11/19/2010 09:13 AM, Tim Gardner wrote:
>>> -------- Original Message --------
>>> Subject: Dell PowerEdge R410 ICH10 SATA support in Ubuntu Hardy
>>> Date: Fri, 12 Nov 2010 16:23:38 -0500
>>> From: Eric des Courtis<Eric.desCourtis@benbria.com>
>>> To: tim.gardner@canonical.com
>>>
>>>
>>>
>>> Tim,
>>>
>>> Attached is a bundle containing my changes to the ubuntu hardy kernel
>>> repository ( git://kernel.ubuntu.com/ubuntu/ubuntu-hardy.git
>>> <http://kernel.ubuntu.com/ubuntu/ubuntu-hardy.git> ). It adds support
>>> for the ICH10 SATA controller found in the Dell PowerEdge R410 server.
>>>
>>> If you have any questions please let me know.
>>>
>>> Cheers.
>>>
>>>
>>> Eric des Courtis
>>>
>>> PS: Continue the great work!
>>
>
> I'm surprised that ICH10 works just by enabling the PCI ID.
>
> In order to have this patch considered for inclusion in Hardy you'll
> have to follow the SRU process. See
>
> https://wiki.ubuntu.com/KernelTeam/StableKernelMaintenance
>
> rtg

Oh, and one more comment. It is the attitude of most upstream developers 
that copyright assignment is only granted for patches that change a 
substantial amount of code (which this patch does not). Furthermore, I 
won't accept a patch with copyright assignment unless it is also 
accepted by the original author(s).

rtg

Patch

From 03ccc635b7eed87418d46a6ec0e4430d83865cbc Mon Sep 17 00:00:00 2001
From: Eric des Courtis <eric.des.courtis@benbria.ca>
Date: Fri, 12 Nov 2010 12:26:15 -0500
Subject: [PATCH] Added missing support for ICH10 often found in Dell R410 Servers

---
 drivers/ata/ata_piix.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index 4d769b8..af8f4ac 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -15,6 +15,7 @@ 
  *  Copyright (C) 1998-1999 Andrzej Krzysztofowicz, Author and Maintainer
  *  Copyright (C) 1998-2000 Andre Hedrick <andre@linux-ide.org>
  *  Copyright (C) 2003 Red Hat Inc <alan@redhat.com>
+ *  Copyright (C) 2010 Eric des Courtis <eric.des.courtis@benbria.com>
  *
  *
  *  This program is free software; you can redistribute it and/or modify
@@ -80,6 +81,9 @@ 
  *	ICH3    errata #15      - IDE deadlock under high load
  *				  (BIOS must set dev 31 fn 0 bit 23)
  *	ICH3	errata #18	- Don't use native mode
+ *      
+ * NOTE:
+ *	Back port of ICH10 support for Dell PowerEdge R410 SATA controller (Eric des Courtis)
  */
 
 #include <linux/kernel.h>
@@ -263,6 +267,14 @@  static const struct pci_device_id piix_pci_tbl[] = {
 	{ 0x8086, 0x292e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
 	/* SATA Controller IDE (Tolapai) */
 	{ 0x8086, 0x5028, PCI_ANY_ID, PCI_ANY_ID, 0, 0, tolapai_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a00, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a06, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a20, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_ahci },
+	/* SATA Controller IDE (ICH10) */
+	{ 0x8086, 0x3a26, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
 
 	{ }	/* terminate list */
 };
-- 
1.7.0.4