Patchwork [U-Boot,v2,2/2] Sheevaplug: Add MMC/SDIO support

login
register
mail settings
Submitter Gérald Kerma
Date Nov. 19, 2010, 4:11 p.m.
Message ID <4CE6A1B2.1040100@gmail.com>
Download mbox | patch
Permalink /patch/72265/
State Changes Requested
Delegated to: Andy Fleming
Headers show

Comments

Gérald Kerma - Nov. 19, 2010, 4:11 p.m.
---
 include/configs/sheevaplug.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Ludovic =?iso-8859-1?Q?Court=E8s?= - Nov. 20, 2010, 3:17 p.m.
Hi,

Gérald Kerma <geraker@gmail.com> writes:

>  /*
> + * SDIO/MMC Card Configuration
> + */
> +#ifdef CONFIG_CMD_MMC
> +#define CONFIG_MMC
> +#define CONFIG_MV_SDIO
> +#endif /* CONFIG_CMD_MMC */
> +

Speaking of this, I suggested enabling MMC, ext2, and other features by
default for the GuruPlug [0], but my understanding was that this was
being factorized between the SheevaPlug and GuruPlug.

What’s the status of this refactoring effort?

Thanks,
Ludo’.

[0] http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/85857
Prafulla Wadaskar - Nov. 20, 2010, 9:33 p.m.
> -----Original Message-----
> From: Gérald Kerma [mailto:geraker@gmail.com]
> Sent: Friday, November 19, 2010 9:42 PM
> To: Prafulla Wadaskar
> Cc: u-boot@lists.denx.de; Clint Adams
> Subject: [PATCH v2 2/2] Sheevaplug: Add MMC/SDIO support
> 
> ---
>  include/configs/sheevaplug.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
> index 83dd8ff..b944ec7 100644
> --- a/include/configs/sheevaplug.h
> +++ b/include/configs/sheevaplug.h
> @@ -47,6 +47,7 @@
>  #define CONFIG_CMD_DHCP
>  #define CONFIG_CMD_ENV
>  #define CONFIG_CMD_MII
> +#define CONFIG_CMD_MMC
>  #define CONFIG_CMD_NAND
>  #define CONFIG_CMD_PING
>  #define CONFIG_CMD_USB
> @@ -90,6 +91,14 @@
>  	"x_bootargs_root=root=/dev/mtdblock3 rw rootfstype=jffs2\0"
> 
>  /*
> + * SDIO/MMC Card Configuration
> + */
> +#ifdef CONFIG_CMD_MMC
> +#define CONFIG_MMC
> +#define CONFIG_MV_SDIO
> +#endif /* CONFIG_CMD_MMC */

Please move this to mv-common.h, I think you have not synced with latest u-boot.

Regards..
Prafulla ..
Prafulla Wadaskar - Nov. 20, 2010, 9:42 p.m.
> -----Original Message-----
> From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de]
> On Behalf Of Ludovic Courtès
> Sent: Saturday, November 20, 2010 8:47 PM
> To: u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH v2 2/2] Sheevaplug: Add MMC/SDIO support
> 
> Hi,
> 
> Gérald Kerma <geraker@gmail.com> writes:
> 
> >  /*
> > + * SDIO/MMC Card Configuration
> > + */
> > +#ifdef CONFIG_CMD_MMC
> > +#define CONFIG_MMC
> > +#define CONFIG_MV_SDIO
> > +#endif /* CONFIG_CMD_MMC */
> > +
> 
> Speaking of this, I suggested enabling MMC, ext2, and other features by
> default for the GuruPlug [0], but my understanding was that this was
> being factorized between the SheevaPlug and GuruPlug.
> 
> What's the status of this refactoring effort?

Guruplug and Sheevaplug are two different boards with h/w diffs, 
We have introduced mv-common.h for this,

There are some early sheevaplug versions (without wifi), this patch may help for it.

Regards..
Prafulla ..

Patch

diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
index 83dd8ff..b944ec7 100644
--- a/include/configs/sheevaplug.h
+++ b/include/configs/sheevaplug.h
@@ -47,6 +47,7 @@ 
 #define CONFIG_CMD_DHCP
 #define CONFIG_CMD_ENV
 #define CONFIG_CMD_MII
+#define CONFIG_CMD_MMC
 #define CONFIG_CMD_NAND
 #define CONFIG_CMD_PING
 #define CONFIG_CMD_USB
@@ -90,6 +91,14 @@ 
 	"x_bootargs_root=root=/dev/mtdblock3 rw rootfstype=jffs2\0"

 /*
+ * SDIO/MMC Card Configuration
+ */
+#ifdef CONFIG_CMD_MMC
+#define CONFIG_MMC
+#define CONFIG_MV_SDIO
+#endif /* CONFIG_CMD_MMC */
+
+/*
  * Ethernet Driver configuration
  */
 #ifdef CONFIG_CMD_NET