Patchwork [V2] omap: nand: remove hardware ECC as default

login
register
mail settings
Submitter Sukumar Ghorai
Date Nov. 19, 2010, 2:45 p.m.
Message ID <1290177926-3526-1-git-send-email-s-ghorai@ti.com>
Download mbox | patch
Permalink /patch/72255/
State New
Headers show

Comments

Sukumar Ghorai - Nov. 19, 2010, 2:45 p.m.
CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
This flag enables hw ecc by default. Boards like beagle and pandora uses
sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
https://patchwork.kernel.org/patch/111036/

Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
---
 drivers/mtd/nand/omap2.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Tony Lindgren - Nov. 30, 2010, 6:05 p.m.
* Sukumar Ghorai <s-ghorai@ti.com> [101119 06:36]:
> CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
> This flag enables hw ecc by default. Boards like beagle and pandora uses
> sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
> https://patchwork.kernel.org/patch/111036/
> 
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>

This should go in as a fix for the -rc via MTD list if possible.

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/mtd/nand/omap2.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index cd41c58..15682ec 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -7,7 +7,6 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   */
> -#define CONFIG_MTD_NAND_OMAP_HWECC
>  
>  #include <linux/platform_device.h>
>  #include <linux/dma-mapping.h>
> -- 
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren - Nov. 30, 2010, 6:09 p.m.
* Tony Lindgren <tony@atomide.com> [101130 09:56]:
> * Sukumar Ghorai <s-ghorai@ti.com> [101119 06:36]:
> > CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
> > This flag enables hw ecc by default. Boards like beagle and pandora uses
> > sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
> > https://patchwork.kernel.org/patch/111036/

Although instead of the link above it should say:

Commit 2c01946c6b9ebaa5a89710bc42ca224a7f52f227 (omap3 nand: cleanup
virtual address usages) wrongly enabled CONFIG_MTD_NAND_OMAP_HWECC
which breaks boards like beagle and pandora that use software ECC
for write.
 
> > Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> 
> This should go in as a fix for the -rc via MTD list if possible.
> 
> Acked-by: Tony Lindgren <tony@atomide.com>
> 
> > ---
> >  drivers/mtd/nand/omap2.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> > index cd41c58..15682ec 100644
> > --- a/drivers/mtd/nand/omap2.c
> > +++ b/drivers/mtd/nand/omap2.c
> > @@ -7,7 +7,6 @@
> >   * it under the terms of the GNU General Public License version 2 as
> >   * published by the Free Software Foundation.
> >   */
> > -#define CONFIG_MTD_NAND_OMAP_HWECC
> >  
> >  #include <linux/platform_device.h>
> >  #include <linux/dma-mapping.h>
> > -- 
> > 1.7.0.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Artem Bityutskiy - Dec. 3, 2010, 4:22 p.m.
On Tue, 2010-11-30 at 10:05 -0800, Tony Lindgren wrote:
> * Sukumar Ghorai <s-ghorai@ti.com> [101119 06:36]:
> > CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
> > This flag enables hw ecc by default. Boards like beagle and pandora uses
> > sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
> > https://patchwork.kernel.org/patch/111036/
> > 
> > Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> 
> This should go in as a fix for the -rc via MTD list if possible.
> 
> Acked-by: Tony Lindgren <tony@atomide.com>

Tony, I think this is quite simple patch, and you can merge it yourself,
MTD tree is slow. I hope dwmw2 will not beat me for this, but unless he
quickly jumps in and confirms he takes care of this patch, just go ahead
an merge it. I've put dwmw2 to "To:", just in case.
David Woodhouse - Dec. 3, 2010, 4:38 p.m.
On Fri, 2010-12-03 at 18:22 +0200, Artem Bityutskiy wrote:
> On Tue, 2010-11-30 at 10:05 -0800, Tony Lindgren wrote:
> > * Sukumar Ghorai <s-ghorai@ti.com> [101119 06:36]:
> > > CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
> > > This flag enables hw ecc by default. Boards like beagle and pandora uses
> > > sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
> > > https://patchwork.kernel.org/patch/111036/
> > > 
> > > Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> > 
> > This should go in as a fix for the -rc via MTD list if possible.
> > 
> > Acked-by: Tony Lindgren <tony@atomide.com>
> 
> Tony, I think this is quite simple patch, and you can merge it yourself,
> MTD tree is slow. I hope dwmw2 will not beat me for this, but unless he
> quickly jumps in and confirms he takes care of this patch, just go ahead
> an merge it. I've put dwmw2 to "To:", just in case.

Acked-by: David Woodhouse <David.Woodhouse@intel.com>

Unless you'd prefer me to send it on myself, please feel free to submit
it to Linus directly.
Tony Lindgren - Dec. 3, 2010, 4:44 p.m.
* David Woodhouse <dwmw2@infradead.org> [101203 08:29]:
> On Fri, 2010-12-03 at 18:22 +0200, Artem Bityutskiy wrote:
> > On Tue, 2010-11-30 at 10:05 -0800, Tony Lindgren wrote:
> > > * Sukumar Ghorai <s-ghorai@ti.com> [101119 06:36]:
> > > > CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
> > > > This flag enables hw ecc by default. Boards like beagle and pandora uses
> > > > sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
> > > > https://patchwork.kernel.org/patch/111036/
> > > > 
> > > > Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> > > 
> > > This should go in as a fix for the -rc via MTD list if possible.
> > > 
> > > Acked-by: Tony Lindgren <tony@atomide.com>
> > 
> > Tony, I think this is quite simple patch, and you can merge it yourself,
> > MTD tree is slow. I hope dwmw2 will not beat me for this, but unless he
> > quickly jumps in and confirms he takes care of this patch, just go ahead
> > an merge it. I've put dwmw2 to "To:", just in case.
> 
> Acked-by: David Woodhouse <David.Woodhouse@intel.com>
> 
> Unless you'd prefer me to send it on myself, please feel free to submit
> it to Linus directly.

Thanks, I'll queue it.

Regards,

Tony

Patch

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index cd41c58..15682ec 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -7,7 +7,6 @@ 
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
-#define CONFIG_MTD_NAND_OMAP_HWECC
 
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>