| Message ID | 20170201104514.GB287@x4 |
|---|---|
| State | New |
| Headers | show |
On Wed, Feb 01, 2017 at 11:45:14AM +0100, Markus Trippelsdorf wrote: > Some colors on e.g. https://gcc.gnu.org/gcc-7/changes.html are nearly > unreadable. So what about the following patch? > > --- gcc_orig.css 2017-02-01 11:39:17.634017498 +0100 > +++ gcc.css 2017-02-01 11:40:23.979244263 +0100 > @@ -58,8 +58,8 @@ > } > div.copyright p:nth-child(3) { margin-bottom: 0; } > > -.boldcyan { font-weight:bold; color:cyan; } > -.boldlime { font-weight:bold; color:lime; } > +.boldcyan { font-weight:bold; color:#25a9a9; } > +.boldlime { font-weight:bold; color:green;} > .boldmagenta { font-weight:bold; color:magenta; } > .boldred { font-weight:bold; color:red; } > .boldblue { font-weight:bold; color:blue; } I think the intent is that they actually match closely what gcc/libasan emits (that of course depends on the exact terminal setting). So are your colors closer to what gcc/libasan print or not? Jakub
On 2017.02.01 at 11:48 +0100, Jakub Jelinek wrote: > On Wed, Feb 01, 2017 at 11:45:14AM +0100, Markus Trippelsdorf wrote: > > Some colors on e.g. https://gcc.gnu.org/gcc-7/changes.html are nearly > > unreadable. So what about the following patch? > > > > --- gcc_orig.css 2017-02-01 11:39:17.634017498 +0100 > > +++ gcc.css 2017-02-01 11:40:23.979244263 +0100 > > @@ -58,8 +58,8 @@ > > } > > div.copyright p:nth-child(3) { margin-bottom: 0; } > > > > -.boldcyan { font-weight:bold; color:cyan; } > > -.boldlime { font-weight:bold; color:lime; } > > +.boldcyan { font-weight:bold; color:#25a9a9; } > > +.boldlime { font-weight:bold; color:green;} > > .boldmagenta { font-weight:bold; color:magenta; } > > .boldred { font-weight:bold; color:red; } > > .boldblue { font-weight:bold; color:blue; } > > I think the intent is that they actually match closely what gcc/libasan emits > (that of course depends on the exact terminal setting). > So are your colors closer to what gcc/libasan print or not? As you said, the exact terminal colors are user definable. But yes, the change above bring them closer to what I see in my terminal. And readability is much improved by the patch IMHO.
On Wed, 1 Feb 2017, Markus Trippelsdorf wrote: > Some colors on e.g. https://gcc.gnu.org/gcc-7/changes.html are nearly > unreadable. I recently noticed that gcc's website has an extremely strict Content Security Policy, which makes it harder to customize its appearance using for instance greasemonkey in firefox. Arguably, greasemonkey should disable CSP checks for the content injected by its scripts, and I can always make my browser pretend that gcc is returning a different CSP, but that seems complicated and unnecessary. Would it be possible to allow unsafe-inline in style-src (assuming I read the doc correctly)? Possibly relax things even more if it helps other customization tools?
On Wed, Feb 01, 2017 at 11:55:53AM +0100, Markus Trippelsdorf wrote: > On 2017.02.01 at 11:48 +0100, Jakub Jelinek wrote: > > On Wed, Feb 01, 2017 at 11:45:14AM +0100, Markus Trippelsdorf wrote: > > > Some colors on e.g. https://gcc.gnu.org/gcc-7/changes.html are nearly > > > unreadable. So what about the following patch? > > > > > > --- gcc_orig.css 2017-02-01 11:39:17.634017498 +0100 > > > +++ gcc.css 2017-02-01 11:40:23.979244263 +0100 > > > @@ -58,8 +58,8 @@ > > > } > > > div.copyright p:nth-child(3) { margin-bottom: 0; } > > > > > > -.boldcyan { font-weight:bold; color:cyan; } > > > -.boldlime { font-weight:bold; color:lime; } > > > +.boldcyan { font-weight:bold; color:#25a9a9; } > > > +.boldlime { font-weight:bold; color:green;} > > > .boldmagenta { font-weight:bold; color:magenta; } > > > .boldred { font-weight:bold; color:red; } > > > .boldblue { font-weight:bold; color:blue; } > > > > I think the intent is that they actually match closely what gcc/libasan emits > > (that of course depends on the exact terminal setting). > > So are your colors closer to what gcc/libasan print or not? > > As you said, the exact terminal colors are user definable. > But yes, the change above bring them closer to what I see in my > terminal. Exactly the opposite here, the current colors match very closely what I get (gnome-terminal, White on black, Linux console color set), your colors are completely different. E.g. in changes.html, the Asan spans with boldlime are using \033[1m\033[32m in libsanitizer, and the note color in gcc by default is \033[1m\033[36m I've tried various color settings of gnome-terminal (both white on black and black on white plus the different color sets) and all of them except for Solarized (which is shades of grey) look much brighter than your colors. Jakub
On 2017.02.01 at 12:14 +0100, Jakub Jelinek wrote: > On Wed, Feb 01, 2017 at 11:55:53AM +0100, Markus Trippelsdorf wrote: > > On 2017.02.01 at 11:48 +0100, Jakub Jelinek wrote: > > > On Wed, Feb 01, 2017 at 11:45:14AM +0100, Markus Trippelsdorf wrote: > > > > Some colors on e.g. https://gcc.gnu.org/gcc-7/changes.html are nearly > > > > unreadable. So what about the following patch? > > > > > > > > --- gcc_orig.css 2017-02-01 11:39:17.634017498 +0100 > > > > +++ gcc.css 2017-02-01 11:40:23.979244263 +0100 > > > > @@ -58,8 +58,8 @@ > > > > } > > > > div.copyright p:nth-child(3) { margin-bottom: 0; } > > > > > > > > -.boldcyan { font-weight:bold; color:cyan; } > > > > -.boldlime { font-weight:bold; color:lime; } > > > > +.boldcyan { font-weight:bold; color:#25a9a9; } > > > > +.boldlime { font-weight:bold; color:green;} > > > > .boldmagenta { font-weight:bold; color:magenta; } > > > > .boldred { font-weight:bold; color:red; } > > > > .boldblue { font-weight:bold; color:blue; } > > > > > > I think the intent is that they actually match closely what gcc/libasan emits > > > (that of course depends on the exact terminal setting). > > > So are your colors closer to what gcc/libasan print or not? > > > > As you said, the exact terminal colors are user definable. > > But yes, the change above bring them closer to what I see in my > > terminal. > > Exactly the opposite here, the current colors match very closely what I get > (gnome-terminal, White on black, Linux console color set), > your colors are completely different. > > E.g. in changes.html, the Asan spans with boldlime are using > \033[1m\033[32m > in libsanitizer, and the note color in gcc by default is > \033[1m\033[36m > > I've tried various color settings of gnome-terminal (both white on black and > black on white plus the different color sets) and all of them except > for Solarized (which is shades of grey) look much brighter than your colors. See: http://i.imgur.com/rAlEdVy.png. (I use konsole, but even gnome- terminal supports truecolor now. So one has complete freedom in choosing the default colors.)
On Wed, Feb 01, 2017 at 12:33:30PM +0100, Markus Trippelsdorf wrote: > > E.g. in changes.html, the Asan spans with boldlime are using > > \033[1m\033[32m > > in libsanitizer, and the note color in gcc by default is > > \033[1m\033[36m > > > > I've tried various color settings of gnome-terminal (both white on black and > > black on white plus the different color sets) and all of them except > > for Solarized (which is shades of grey) look much brighter than your colors. > > See: http://i.imgur.com/rAlEdVy.png. (I use konsole, but even gnome- > terminal supports truecolor now. So one has complete freedom in choosing > the default colors.) Sure, one can customize anything. The point is, what colors are configured by default and thus used by most of the users? Just tried konsole (both Linux colors and Black on white) look like this http://imgur.com/pQS6lbI Jakub
On 2017.02.01 at 12:41 +0100, Jakub Jelinek wrote: > Hi! > > On Wed, Feb 01, 2017 at 12:27:05PM +0100, Markus Trippelsdorf wrote: > > > I've tried various color settings of gnome-terminal (both white on black and > > > black on white plus the different color sets) and all of them except > > > for Solarized (which is shades of grey) look much brighter than your colors. > > > > See attached screenshot. (I use konsole, but even gnome-terminal > > supports truecolor now. So one has complete freedom in choosing the > > default colors.) > > Sure, one can customize anything. The point is, what colors are configured > by default and thus used by most of the users? > > Just tried konsole (both Linux colors and Black on white) look like this > here: This points to the core of the issue. I guess most users use a dark (black) background in the terminal. And on a black background the gcc.css colors are perfectly readable. But because we use a white background on the website, the colors have way too little contrast and become hard to read.
Hi Markus, On Wed, 1 Feb 2017, Markus Trippelsdorf wrote: > Some colors on e.g. https://gcc.gnu.org/gcc-7/changes.html are nearly > unreadable. So what about the following patch? > > -.boldcyan { font-weight:bold; color:cyan; } > -.boldlime { font-weight:bold; color:lime; } > +.boldcyan { font-weight:bold; color:#25a9a9; } > +.boldlime { font-weight:bold; color:green;} just want to follow-up on this and the discussion that ensued. Based on the feedback you got from Jakub and others, I am not comfortable making this change (so if we had a patch tracker, would label this as "declined"). Gerald
--- gcc_orig.css 2017-02-01 11:39:17.634017498 +0100 +++ gcc.css 2017-02-01 11:40:23.979244263 +0100 @@ -58,8 +58,8 @@ } div.copyright p:nth-child(3) { margin-bottom: 0; } -.boldcyan { font-weight:bold; color:cyan; } -.boldlime { font-weight:bold; color:lime; } +.boldcyan { font-weight:bold; color:#25a9a9; } +.boldlime { font-weight:bold; color:green;} .boldmagenta { font-weight:bold; color:magenta; } .boldred { font-weight:bold; color:red; } .boldblue { font-weight:bold; color:blue; }