From patchwork Fri Nov 19 11:34:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Henningsson X-Patchwork-Id: 72242 X-Patchwork-Delegate: tim.gardner@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 9794A1007D2 for ; Fri, 19 Nov 2010 22:34:55 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1PJPEq-0006j9-Ix; Fri, 19 Nov 2010 11:34:44 +0000 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1PJPEo-0006j4-Kz for kernel-team@lists.ubuntu.com; Fri, 19 Nov 2010 11:34:42 +0000 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1PJPEo-0005eN-Je; Fri, 19 Nov 2010 11:34:42 +0000 Received: from c-83-233-18-148.cust.bredband2.com ([83.233.18.148] helo=[192.168.8.102]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1PJPEo-0001Wm-FO; Fri, 19 Nov 2010 11:34:42 +0000 Message-ID: <4CE660D2.8060906@canonical.com> Date: Fri, 19 Nov 2010 12:34:42 +0100 From: David Henningsson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Brad Figg Subject: Re: [Maverick SRU] [PATCH]: Acer aspire 7736 - Playback not working References: <4CDBC26E.7010103@canonical.com> <4CE2844E.4000400@canonical.com> <4CE32C72.2080908@canonical.com> In-Reply-To: <4CE32C72.2080908@canonical.com> Cc: kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com On 2010-11-17 02:14, Brad Figg wrote: > On 11/16/2010 05:17 AM, David Henningsson wrote: >> Attaching modified patches according to your wishes. >> >> On 2010-11-11 11:16, David Henningsson wrote: >>> BugLink: https://launchpad.net/bugs/617647 >>> >>> SRU Justification: >>> >>> Impact: A regression in Maverick caused audio playback to stop working >>> on Acer aspire 7736. >>> >>> Fix: Require some new low-impact quirk infrastructure plus the actual >>> quirk. >>> >>> Testcase: Try playing back through internal speakers and headphones on >>> the machine. >>> >>> Both patches has been accepted upstream (as commits 90622917 and >>> c3d226ab) but it does not make sense to send to stable@kernel.org since >>> 2.6.35 isn't maintained anymore. >>> >> >> > > David, > > The second patch doesn't apply cleanly against Maverick. Did you apply > it against Maverick and build it? Ok, 3rd attempt - these both apply and build with ubuntu-maverick.git. I keep my fingers crossed that things will work now and that the community will test accordingly, so that it doesn't get reverted. From cebe004745a54b5dec1cdfa2f8ce9708c301941a Mon Sep 17 00:00:00 2001 From: David Henningsson Date: Thu, 14 Oct 2010 15:42:08 +0200 Subject: [PATCH 2/2] ALSA: HDA: Apply SKU override for Acer aspire 7736z BugLink: http://launchpad.net/bugs/617647 The current SKU value disables playback, so ignore the SKU value. Committed as c3d226ab8b44fe31e5e6d5739eb353597cea4029 in linux-2.6. Signed-off-by: David Henningsson --- sound/pci/hda/patch_realtek.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 8fc8925..f73f732 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10297,7 +10297,8 @@ static struct alc_config_preset alc882_presets[] = { * Pin config fixes */ enum { - PINFIX_ABIT_AW9D_MAX + PINFIX_ABIT_AW9D_MAX, + PINFIX_ACER_ASPIRE_7736, }; static struct alc_pincfg alc882_abit_aw9d_pinfix[] = { @@ -10311,10 +10312,14 @@ static const struct alc_fixup alc882_fixups[] = { [PINFIX_ABIT_AW9D_MAX] = { .pins = alc882_abit_aw9d_pinfix }, + [PINFIX_ACER_ASPIRE_7736] = { + .sku = ALC_FIXUP_SKU_IGNORE, + }, }; static struct snd_pci_quirk alc882_fixup_tbl[] = { SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", PINFIX_ABIT_AW9D_MAX), + SND_PCI_QUIRK(0x1025, 0x0296, "Acer Aspire 7736z", PINFIX_ACER_ASPIRE_7736), {} }; -- 1.7.1