diff mbox

powerpc/powermac: drop useless call to of_find_node_by_name

Message ID 20170131180144.GA27740@dtor-ws (mailing list archive)
State Accepted
Commit df26200299eb05fa7d059cd235847efc4c4baf80
Headers show

Commit Message

Dmitry Torokhov Jan. 31, 2017, 6:01 p.m. UTC
We are not using result, so this simply results in a leaked refcount.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

Found by visual inspection, not tested...

 arch/powerpc/platforms/powermac/feature.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Michael Ellerman Dec. 12, 2017, 11:39 a.m. UTC | #1
On Tue, 2017-01-31 at 18:01:44 UTC, Dmitry Torokhov wrote:
> We are not using result, so this simply results in a leaked refcount.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/df26200299eb05fa7d059cd235847e

cheers
diff mbox

Patch

diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index 1e02328c3f2d..730e48111848 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c
@@ -2853,7 +2853,6 @@  set_initial_features(void)
 		}
 
 		/* Enable ATA-100 before PCI probe. */
-		np = of_find_node_by_name(NULL, "ata-6");
 		for_each_node_by_name(np, "ata-6") {
 			if (np->parent
 			    && of_device_is_compatible(np->parent, "uni-north")