diff mbox

powerpc/powermac: fix OF node refcount leak

Message ID 20170131174355.GA25198@dtor-ws (mailing list archive)
State Accepted
Commit 2aaf0a198d7af53a946ad69976d3cc7e7673d13f
Headers show

Commit Message

Dmitry Torokhov Jan. 31, 2017, 5:43 p.m. UTC 
We need to call of_node_put() for device nodes obtained with
of_find_node_by_name().

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

Found by visual inspection, not tested...

 arch/powerpc/platforms/powermac/pic.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Ellerman Dec. 12, 2017, 11:39 a.m. UTC | #1 
On Tue, 2017-01-31 at 17:43:55 UTC, Dmitry Torokhov wrote:
> We need to call of_node_put() for device nodes obtained with
> of_find_node_by_name().
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/2aaf0a198d7af53a946ad69976d3cc

cheers
diff mbox

Patch

diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c
index f5f9ad7c3398..d3a9ab0dbcb1 100644
--- a/arch/powerpc/platforms/powermac/pic.c
+++ b/arch/powerpc/platforms/powermac/pic.c
@@ -604,6 +604,7 @@  static int pmacpic_find_viaint(void)
 	if (np == NULL)
 		goto not_found;
 	viaint = irq_of_parse_and_map(np, 0);
+	of_node_put(np);
 
 not_found:
 #endif /* CONFIG_ADB_PMU */