diff mbox

acpi: slic: make variable table static

Message ID 20170130171615.6708-1-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King Jan. 30, 2017, 5:16 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

table is currently in global scope and doesn't need to be. Make
it static.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/slic/slic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ivan Hu Feb. 2, 2017, 7:05 a.m. UTC | #1 
On 2017年01月31日 01:16, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> table is currently in global scope and doesn't need to be. Make
> it static.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/slic/slic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/slic/slic.c b/src/acpi/slic/slic.c
> index a1a47ab..d59f929 100644
> --- a/src/acpi/slic/slic.c
> +++ b/src/acpi/slic/slic.c
> @@ -30,7 +30,7 @@
>
>  #define	DUMP_SLIC	(0)	/* Disable this, just used it for debugging */
>
> -fwts_acpi_table_info *table;
> +static fwts_acpi_table_info *table;
>
>  static int slic_init(fwts_framework *fw)
>  {
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung Feb. 3, 2017, 3:25 a.m. UTC | #2 
On 2017-01-31 01:16 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> table is currently in global scope and doesn't need to be. Make
> it static.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/slic/slic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/slic/slic.c b/src/acpi/slic/slic.c
> index a1a47ab..d59f929 100644
> --- a/src/acpi/slic/slic.c
> +++ b/src/acpi/slic/slic.c
> @@ -30,7 +30,7 @@
>
>  #define	DUMP_SLIC	(0)	/* Disable this, just used it for debugging */
>
> -fwts_acpi_table_info *table;
> +static fwts_acpi_table_info *table;
>
>  static int slic_init(fwts_framework *fw)
>  {
>

Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/slic/slic.c b/src/acpi/slic/slic.c
index a1a47ab..d59f929 100644
--- a/src/acpi/slic/slic.c
+++ b/src/acpi/slic/slic.c
@@ -30,7 +30,7 @@ 
 
 #define	DUMP_SLIC	(0)	/* Disable this, just used it for debugging */
 
-fwts_acpi_table_info *table;
+static fwts_acpi_table_info *table;
 
 static int slic_init(fwts_framework *fw)
 {