Message ID | 20170130171240.5209-1-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
On 2017年01月31日 01:12, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > table is currently in global scope and doesn't need to be. Make > it static. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/slit/slit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/slit/slit.c b/src/acpi/slit/slit.c > index b495c2a..9b7fbf8 100644 > --- a/src/acpi/slit/slit.c > +++ b/src/acpi/slit/slit.c > @@ -30,7 +30,7 @@ > > #define INDEX(i, j) (((i) * slit->num_of_system_localities) + (j)) > > -fwts_acpi_table_info *table; > +static fwts_acpi_table_info *table; > > static int slit_init(fwts_framework *fw) > { > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 2017-01-31 01:12 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > table is currently in global scope and doesn't need to be. Make > it static. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpi/slit/slit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/slit/slit.c b/src/acpi/slit/slit.c > index b495c2a..9b7fbf8 100644 > --- a/src/acpi/slit/slit.c > +++ b/src/acpi/slit/slit.c > @@ -30,7 +30,7 @@ > > #define INDEX(i, j) (((i) * slit->num_of_system_localities) + (j)) > > -fwts_acpi_table_info *table; > +static fwts_acpi_table_info *table; > > static int slit_init(fwts_framework *fw) > { > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/acpi/slit/slit.c b/src/acpi/slit/slit.c index b495c2a..9b7fbf8 100644 --- a/src/acpi/slit/slit.c +++ b/src/acpi/slit/slit.c @@ -30,7 +30,7 @@ #define INDEX(i, j) (((i) * slit->num_of_system_localities) + (j)) -fwts_acpi_table_info *table; +static fwts_acpi_table_info *table; static int slit_init(fwts_framework *fw) {