From patchwork Thu Nov 18 22:16:44 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vladimir Kargov X-Patchwork-Id: 72157 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8FE49B71F1 for ; Fri, 19 Nov 2010 09:17:24 +1100 (EST) Received: (qmail 25392 invoked by alias); 18 Nov 2010 22:17:23 -0000 Received: (qmail 25384 invoked by uid 22791); 18 Nov 2010 22:17:22 -0000 X-SWARE-Spam-Status: No, hits=0.5 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-gx0-f175.google.com (HELO mail-gx0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 22:17:18 +0000 Received: by gxk2 with SMTP id 2so2406540gxk.20 for ; Thu, 18 Nov 2010 14:17:16 -0800 (PST) Received: by 10.150.57.6 with SMTP id f6mr2090186yba.198.1290118624302; Thu, 18 Nov 2010 14:17:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.151.51.6 with HTTP; Thu, 18 Nov 2010 14:16:44 -0800 (PST) In-Reply-To: References: From: Vladimir Kargov Date: Fri, 19 Nov 2010 01:16:44 +0300 Message-ID: Subject: [patch][graphite] Invalidate post dominance information after loop closed SSA canonicalization. To: gcc-patches@gcc.gnu.org Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, This patch for the Graphite branch invalidates post dominance information at the end of canonicalize_loop_closed_ssa(), because that function was able to change the CFG of the program without properly correcting or invalidating the post dominance info.        * graphite-scop-detection.c (canonicalize_loop_closed_ssa): Free post        dominance information after loop closed SSA canonicalization. Best regards, --- Vladimir Index: gcc/graphite-scop-detection.c =================================================================== --- gcc/graphite-scop-detection.c (revision 166917) +++ gcc/graphite-scop-detection.c (working copy) @@ -1268,6 +1268,10 @@ canonicalize_loop_closed_ssa (loop_p loop) } } } + + /* The code above does not properly handle changes in the post dominance + information (yet). */ + free_dominance_info (CDI_POST_DOMINATORS); } /* Converts the current loop closed SSA form to a canonical form