Patchwork [wwwdocs] libquadmath: Mention in the news, add to changes.html

login
register
mail settings
Submitter Gerald Pfeifer
Date Nov. 18, 2010, 8:25 p.m.
Message ID <alpine.LNX.2.00.1011182116390.10295@acrux.dbai.tuwien.ac.at>
Download mbox | patch
Permalink /patch/72143/
State New
Headers show

Comments

Gerald Pfeifer - Nov. 18, 2010, 8:25 p.m.
Hi Tobias,

I like this!

On Tue, 16 Nov 2010, Tobias Burnus wrote:
> Do you have comments or suggestions before I install it?

the main page.

And <tt>...</tt> -> <code>...</code> throughout.

+    of magnitute slower than with the 4, 8 or 10 bytes floating-point data types.

magnitude

Thanks!

Gerald
Tobias Burnus - Nov. 19, 2010, 8:57 a.m.
Hi Gerald,

thanks for the review.

On 11/18/2010 09:25 PM, Gerald Pfeifer wrote:
> Index: index.html
> ===================================================================
> +<dt>November 16, 2010</dt>
> +<dd><a href="gcc-4.6/changes.html">GCC 4.6.0</a>  will include the
> +<tt>libquadmath</tt>  library, which provides quad-precision mathematical
> +functions on targets supporting the<tt>__float128</tt>  datatype. The
> +library is used to provide on such targets the<tt>REAL(16)</tt>  type in GNU
> +Fortran compiler. The library has been contributed by Fran&ccedil;ois-Xavier
> +Coudert.</dd>
>
> How about changing the last two sentences
>
>    The library is used to provide on such targets the<tt>REAL(16)</tt>
>    type in GNU Fortran compiler. The library has been contributed by
>    Fran&ccedil;ois-Xavier Coudert.
> to
>    The library is used to provide the<code>REAL(16)</code>  type on
>    such targets.  It has been contributed by Fran&ccedil;ois-Xavier
>    Coudert.

I like the "on such targets", however, I think one should mention 
Fortran there; for instance: "The library is used to provide the 
<code>REAL(16)</code> type in GNU Fortran on such targets."

I think without mentioning Fortran, not only half of the message is lost 
but it also looks redundant and talking about "REAL(16)" might be 
unclear to non-Fortran users.

I have now committed gcc-4.6/changes.html with your proposed changes and 
index.html with your changes - except for the added "in GNU Fortran".

Tobias

Patch

Index: index.html
===================================================================
+<dt>November 16, 2010</dt>
+<dd><a href="gcc-4.6/changes.html">GCC 4.6.0</a> will include the
+<tt>libquadmath</tt> library, which provides quad-precision mathematical
+functions on targets supporting the <tt>__float128</tt> datatype. The
+library is used to provide on such targets the <tt>REAL(16)</tt> type in GNU
+Fortran compiler. The library has been contributed by Fran&ccedil;ois-Xavier
+Coudert.</dd>

Would you mind using <code>...</code> instead of <tt>...</tt> and
making this a link to gcc-4.6/changes.html#libquadmath (adding that
as an id="libquadmath" at the changes.html page)?

How about changing the last two sentences

  The library is used to provide on such targets the <tt>REAL(16)</tt> 
  type in GNU Fortran compiler. The library has been contributed by 
  Fran&ccedil;ois-Xavier Coudert.

to 

  The library is used to provide the <code>REAL(16)</code> type on
  such targets.  It has been contributed by Fran&ccedil;ois-Xavier 
  Coudert. 
 
?


Index: gcc-4.6/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.6/changes.html,v
retrieving revision 1.58
diff -u -r1.58 changes.html
--- gcc-4.6/changes.html	7 Nov 2010 13:48:21 -0000	1.58
+++ gcc-4.6/changes.html	16 Nov 2010 20:30:46 -0000
@@ -38,6 +38,13 @@ 
     generic link-time optimization framework (LTO) introduced
     in <a href="../gcc-4.5/changes.html">GCC 4.5.0</a>.</li>
 
+    <li>GCC now ships with the LGPL-licensed <tt>libquadmath</tt> library,
+    which provides for targets with a <tt>__float128</tt> datatype
+    quad-precision mathematical functions. <tt>__float128</tt> is available
+    for targets on 32-bit x86, x86-64 and Itanium architectures. The
+    <tt>libquadmath</tt> library is automatically build on such targets
+    when building the Fortran compiler.</tt>

"build" -> "built"

And <li id="libquadmath"> should give you the target for the link from