Patchwork [U-Boot] OMAP4: Panda: Disable CMD_NFS

login
register
mail settings
Submitter Steve Sakoman
Date Nov. 18, 2010, 6:25 p.m.
Message ID <1290104748.2927.1594.camel@quadra>
Download mbox | patch
Permalink /patch/72132/
State Accepted
Commit 8721e95b16024f0a92ccc1cd85aecf6672fe9499
Headers show

Comments

Steve Sakoman - Nov. 18, 2010, 6:25 p.m.
This patch fixes the Panda build after commit 6d8962e814c15807dd6ac5757904be2a02d187b8
by explicitly disabling CMD_NFS

>From the commit message for "Switch from archive libraries to partial linking":

This commit reveals board configurations that exclude some features but
include source files that depend these disabled features in the build,
resulting in undefined symbols.  Known such cases include:

- disabling CMD_NET but not CMD_NFS;
- enabling CONFIG_OF_LIBFDT but not CONFIG_QE.

Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
---
Sandeep Paulraj - Nov. 19, 2010, 4:29 p.m.
> 
> This patch fixes the Panda build after commit
> 6d8962e814c15807dd6ac5757904be2a02d187b8
> by explicitly disabling CMD_NFS
> 
> >From the commit message for "Switch from archive libraries to partial
> linking":
> 
> This commit reveals board configurations that exclude some features but
> include source files that depend these disabled features in the build,
> resulting in undefined symbols.  Known such cases include:
> 
> - disabling CMD_NET but not CMD_NFS;
> - enabling CONFIG_OF_LIBFDT but not CONFIG_QE.
> 
> Signed-off-by: Steve Sakoman <steve.sakoman@linaro.org>
> ---
> 
> diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h
> index e373fe0..8715ed7 100644
> --- a/include/configs/omap4_panda.h
> +++ b/include/configs/omap4_panda.h
> @@ -134,6 +134,7 @@
> 
>  /* Disabled commands */
>  #undef CONFIG_CMD_NET
> +#undef CONFIG_CMD_NFS
>  #undef CONFIG_CMD_FPGA		/* FPGA configuration Support   */
>  #undef CONFIG_CMD_IMLS		/* List all found images        */
> 

Pushed to u-boot-ti

Thanks,
Sandeep

Patch

diff --git a/include/configs/omap4_panda.h b/include/configs/omap4_panda.h
index e373fe0..8715ed7 100644
--- a/include/configs/omap4_panda.h
+++ b/include/configs/omap4_panda.h
@@ -134,6 +134,7 @@ 
 
 /* Disabled commands */
 #undef CONFIG_CMD_NET
+#undef CONFIG_CMD_NFS
 #undef CONFIG_CMD_FPGA		/* FPGA configuration Support   */
 #undef CONFIG_CMD_IMLS		/* List all found images        */