From patchwork Thu Nov 18 18:20:57 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick McHardy X-Patchwork-Id: 72130 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 405F0B71A3 for ; Fri, 19 Nov 2010 05:21:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932550Ab0KRSVB (ORCPT ); Thu, 18 Nov 2010 13:21:01 -0500 Received: from stinky.trash.net ([213.144.137.162]:39344 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408Ab0KRSU7 (ORCPT ); Thu, 18 Nov 2010 13:20:59 -0500 Received: from x100e.localnet (localhost [127.0.0.1]) by stinky.trash.net (Postfix) with ESMTP id 16B73B2C4C; Thu, 18 Nov 2010 19:20:58 +0100 (MET) Message-ID: <4CE56E89.4000902@trash.net> Date: Thu, 18 Nov 2010 19:20:57 +0100 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Thunderbird/3.1.6 MIME-Version: 1.0 To: "Justin P. Mattock" CC: David Miller , eric.dumazet@gmail.com, linux-net@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, horms@verge.net.au, netfilter-devel@vger.kernel.org Subject: Re: error while building the kernel Mainline References: <1290093135.2781.167.camel@edumazet-laptop> <4CE561A2.2020600@gmail.com> <1290102497.2781.242.camel@edumazet-laptop> <20101118.095046.28818361.davem@davemloft.net> <4CE56CC4.4020107@gmail.com> In-Reply-To: <4CE56CC4.4020107@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Am 18.11.2010 19:13, schrieb Justin P. Mattock: > On 11/18/2010 09:50 AM, David Miller wrote: >> From: Eric Dumazet >> Date: Thu, 18 Nov 2010 18:48:17 +0100 >> >>> Let me guess... >>> >>> net/netfilter/nf_conntrack_core is compiled as a module, and ip_vs >>> statically (in vmlinux) ? >>> >>> CONFIG_NF_CONNTRACK=m >>> CONFIG_IP_VS=y >>> >>> We probably need some Kconfig magic ;) >> Please try whether this patch fixes the problem. netfilter: fix IP_VS dependencies When NF_CONNTRACK is enabled, IP_VS uses conntrack symbols. Therefore IP_VS can't be linked statically when conntrack is built modular. Reported-by: Justin P. Mattock Signed-off-by: Patrick McHardy diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig index a22dac2..70bd1d0 100644 --- a/net/netfilter/ipvs/Kconfig +++ b/net/netfilter/ipvs/Kconfig @@ -4,6 +4,7 @@ menuconfig IP_VS tristate "IP virtual server support" depends on NET && INET && NETFILTER + depends on (NF_CONNTRACK || NF_CONNTRACK=n) ---help--- IP Virtual Server support will let you build a high-performance virtual server based on cluster of two or more real servers. This