Patchwork omap: nand: remove hardware ECC as default

login
register
mail settings
Submitter Sukumar Ghorai
Date Nov. 18, 2010, 2:22 p.m.
Message ID <1290090130-20835-1-git-send-email-s-ghorai@ti.com>
Download mbox | patch
Permalink /patch/72097/
State Accepted
Commit 859158bfab7e72af440622fb9731bcaef4e7d6dc
Headers show

Comments

Sukumar Ghorai - Nov. 18, 2010, 2:22 p.m.
CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
that using the hardware ECC by default

Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
---
 drivers/mtd/nand/omap2.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Tony Lindgren - Nov. 18, 2010, 6:01 p.m.
* Sukumar Ghorai <s-ghorai@ti.com> [101118 06:12]:
> CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
> that using the hardware ECC by default
> 
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
>  drivers/mtd/nand/omap2.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index cd41c58..15682ec 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -7,7 +7,6 @@
>   * it under the terms of the GNU General Public License version 2 as
>   * published by the Free Software Foundation.
>   */
> -#define CONFIG_MTD_NAND_OMAP_HWECC
>  
>  #include <linux/platform_device.h>
>  #include <linux/dma-mapping.h>

This looks like a fix for the -rc cycle. Can you please update
the description a bit to specify which commit broke it and
what the error is now?

Regards,

Tony
Grazvydas Ignotas - Nov. 19, 2010, 10:44 a.m.
On Thu, Nov 18, 2010 at 8:01 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Sukumar Ghorai <s-ghorai@ti.com> [101118 06:12]:
>> CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
>> that using the hardware ECC by default

wrongly

>>
>> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
>> ---
>>  drivers/mtd/nand/omap2.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index cd41c58..15682ec 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -7,7 +7,6 @@
>>   * it under the terms of the GNU General Public License version 2 as
>>   * published by the Free Software Foundation.
>>   */
>> -#define CONFIG_MTD_NAND_OMAP_HWECC
>>
>>  #include <linux/platform_device.h>
>>  #include <linux/dma-mapping.h>
>
> This looks like a fix for the -rc cycle. Can you please update
> the description a bit to specify which commit broke it and
> what the error is now?

Well it broke NAND for beagle and pandora at least, as those have been
using sw ecc, all IO simply results in ECC errors with that define.

Patch

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index cd41c58..15682ec 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -7,7 +7,6 @@ 
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
  */
-#define CONFIG_MTD_NAND_OMAP_HWECC
 
 #include <linux/platform_device.h>
 #include <linux/dma-mapping.h>