[RESEND,2/5] dmaengine: Provide a wrapper for memcpy operations

Message ID 1485535324-28393-3-git-send-email-boris.brezillon@free-electrons.com
State Superseded
Delegated to: Boris Brezillon
Headers show

Commit Message

Boris Brezillon Jan. 27, 2017, 4:42 p.m.
Almost all ->device_prep_dma_xx() methods have a wrapper defined in
dmaengine.h. Add one for  ->device_prep_dma_memcpy().

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 include/linux/dmaengine.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Vinod Koul Jan. 30, 2017, 4:54 p.m. | #1
On Fri, Jan 27, 2017 at 05:42:01PM +0100, Boris Brezillon wrote:
> Almost all ->device_prep_dma_xx() methods have a wrapper defined in
> dmaengine.h. Add one for  ->device_prep_dma_memcpy().

Looks good to me.

Acked-by: Vinod Koul <vinod.koul@intel.com>
Boris Brezillon Jan. 30, 2017, 5:47 p.m. | #2
Hi Vinod,

On Mon, 30 Jan 2017 22:24:17 +0530
Vinod Koul <vinod.koul@intel.com> wrote:

> On Fri, Jan 27, 2017 at 05:42:01PM +0100, Boris Brezillon wrote:
> > Almost all ->device_prep_dma_xx() methods have a wrapper defined in
> > dmaengine.h. Add one for  ->device_prep_dma_memcpy().  
> 
> Looks good to me.
> 
> Acked-by: Vinod Koul <vinod.koul@intel.com>
> 
> 

Maybe you can take this patch directly (the NAND related bits are for
4.12).
Vinod Koul Jan. 31, 2017, 3:34 a.m. | #3
On Mon, Jan 30, 2017 at 06:47:21PM +0100, Boris Brezillon wrote:
> Hi Vinod,
> 
> On Mon, 30 Jan 2017 22:24:17 +0530
> Vinod Koul <vinod.koul@intel.com> wrote:
> 
> > On Fri, Jan 27, 2017 at 05:42:01PM +0100, Boris Brezillon wrote:
> > > Almost all ->device_prep_dma_xx() methods have a wrapper defined in
> > > dmaengine.h. Add one for  ->device_prep_dma_memcpy().  
> > 
> > Looks good to me.
> > 
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
> > 
> > 
> 
> Maybe you can take this patch directly (the NAND related bits are for
> 4.12).

Good idea, applied now..

Patch

diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index feee6ec6a13b..533680860865 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -894,6 +894,17 @@  static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_memset(
 						    len, flags);
 }
 
+static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_memcpy(
+		struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
+		size_t len, unsigned long flags)
+{
+	if (!chan || !chan->device || !chan->device->device_prep_dma_memcpy)
+		return NULL;
+
+	return chan->device->device_prep_dma_memcpy(chan, dest, src,
+						    len, flags);
+}
+
 static inline struct dma_async_tx_descriptor *dmaengine_prep_dma_sg(
 		struct dma_chan *chan,
 		struct scatterlist *dst_sg, unsigned int dst_nents,