diff mbox

[6/8] Documentation: dt: Add new compatible to STM32 pinctrl driver bindings

Message ID 1485533721-9019-7-git-send-email-alexandre.torgue@st.com
State New
Headers show

Commit Message

Alexandre TORGUE Jan. 27, 2017, 4:15 p.m. UTC
Add new compatible for stm32f469 MCU.

Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

Comments

Rob Herring Feb. 1, 2017, 3:06 p.m. UTC | #1
On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
> Add new compatible for stm32f469 MCU.
> 
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> index 25d9809..4f0487d 100644
> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
> @@ -9,7 +9,8 @@ Pin controller node:
>  Required properies:
>   - compatible: value should be one of the following:
>     (a) "st,stm32f429-pinctrl"
> -   (b) "st,stm32f746-pinctrl"
> +   (b) "st,stm32f469-pinctrl"
> +   (c) "st,stm32f746-pinctrl"

Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every 
time.

With that,

Acked-by: Rob Herring <robh@kernel.org>


>   - #address-cells: The value of this property must be 1
>   - #size-cells	: The value of this property must be 1
>   - ranges	: defines mapping between pin controller node (parent) to
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre TORGUE Feb. 1, 2017, 3:58 p.m. UTC | #2
On 02/01/2017 04:06 PM, Rob Herring wrote:
> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>> Add new compatible for stm32f469 MCU.
>>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> index 25d9809..4f0487d 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> @@ -9,7 +9,8 @@ Pin controller node:
>>  Required properies:
>>   - compatible: value should be one of the following:
>>     (a) "st,stm32f429-pinctrl"
>> -   (b) "st,stm32f746-pinctrl"
>> +   (b) "st,stm32f469-pinctrl"
>> +   (c) "st,stm32f746-pinctrl"
>
> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
> time.

I completely agree.

Linus, Do i need to send a v2 for this patch ?

>
> With that,
>
> Acked-by: Rob Herring <robh@kernel.org>
>
>
>>   - #address-cells: The value of this property must be 1
>>   - #size-cells	: The value of this property must be 1
>>   - ranges	: defines mapping between pin controller node (parent) to
>> --
>> 1.9.1
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Feb. 6, 2017, 8:46 a.m. UTC | #3
On Wed, Feb 1, 2017 at 4:58 PM, Alexandre Torgue
<alexandre.torgue@st.com> wrote:
> On 02/01/2017 04:06 PM, Rob Herring wrote:
>>
>> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>>>
>>> Add new compatible for stm32f469 MCU.
>>>
>>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> index 25d9809..4f0487d 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>> @@ -9,7 +9,8 @@ Pin controller node:
>>>  Required properies:
>>>   - compatible: value should be one of the following:
>>>     (a) "st,stm32f429-pinctrl"
>>> -   (b) "st,stm32f746-pinctrl"
>>> +   (b) "st,stm32f469-pinctrl"
>>> +   (c) "st,stm32f746-pinctrl"
>>
>>
>> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
>> time.
>
>
> I completely agree.
>
> Linus, Do i need to send a v2 for this patch ?

Nopes, applied the amended v1 patch already with these
changes, check the result.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre TORGUE Feb. 6, 2017, 11:21 a.m. UTC | #4
On 02/06/2017 09:46 AM, Linus Walleij wrote:
> On Wed, Feb 1, 2017 at 4:58 PM, Alexandre Torgue
> <alexandre.torgue@st.com> wrote:
>> On 02/01/2017 04:06 PM, Rob Herring wrote:
>>>
>>> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>>>>
>>>> Add new compatible for stm32f469 MCU.
>>>>
>>>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>>> b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>>> index 25d9809..4f0487d 100644
>>>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>>>> @@ -9,7 +9,8 @@ Pin controller node:
>>>>  Required properies:
>>>>   - compatible: value should be one of the following:
>>>>     (a) "st,stm32f429-pinctrl"
>>>> -   (b) "st,stm32f746-pinctrl"
>>>> +   (b) "st,stm32f469-pinctrl"
>>>> +   (c) "st,stm32f746-pinctrl"
>>>
>>>
>>> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
>>> time.
>>
>>
>> I completely agree.
>>
>> Linus, Do i need to send a v2 for this patch ?
>
> Nopes, applied the amended v1 patch already with these
> changes, check the result.

Thanks Linus!

>
> Yours,
> Linus Walleij
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
index 25d9809..4f0487d 100644
--- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
@@ -9,7 +9,8 @@  Pin controller node:
 Required properies:
  - compatible: value should be one of the following:
    (a) "st,stm32f429-pinctrl"
-   (b) "st,stm32f746-pinctrl"
+   (b) "st,stm32f469-pinctrl"
+   (c) "st,stm32f746-pinctrl"
  - #address-cells: The value of this property must be 1
  - #size-cells	: The value of this property must be 1
  - ranges	: defines mapping between pin controller node (parent) to