| Message ID | 20170126164612.86684-3-manu@bidouilliste.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On 01/26/2017 05:46 PM, Emmanuel Vadot wrote: > Add a FreeBSD option that enables the API and the data cache command > as both are needed to boot the FreeBSD loader. > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > --- > common/Kconfig | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/common/Kconfig b/common/Kconfig > index 9067d1e277..2fe19d354b 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -430,4 +430,13 @@ config BOARD_EARLY_INIT_F > > endmenu > > +config FREEBSD > + bool "Enable FreeBSD boot" > + select API > + select CMD_CACHE > + default n > + help > + This options adds boot configuration that can run the FreeBSD The help text should be more descriptive and actually tell users what the option really does. Since the only thing CONFIG_FREEBSD does now is to enable distro boot support for it, maybe even rename the the option into CONFIG_DISTRO_FREEBSD. Alex
On 01/26/2017 05:46 PM, Emmanuel Vadot wrote: > Add a FreeBSD option that enables the API and the data cache command > as both are needed to boot the FreeBSD loader. > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> Also, please make this patch 4/4 so that the set is well bisectable. Alex
On Thu, 26 Jan 2017 18:08:49 +0100 Alexander Graf <agraf@suse.de> wrote: > On 01/26/2017 05:46 PM, Emmanuel Vadot wrote: > > Add a FreeBSD option that enables the API and the data cache command > > as both are needed to boot the FreeBSD loader. > > > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > > --- > > common/Kconfig | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/common/Kconfig b/common/Kconfig > > index 9067d1e277..2fe19d354b 100644 > > --- a/common/Kconfig > > +++ b/common/Kconfig > > @@ -430,4 +430,13 @@ config BOARD_EARLY_INIT_F > > > > endmenu > > > > +config FREEBSD > > + bool "Enable FreeBSD boot" > > + select API > > + select CMD_CACHE > > + default n > > + help > > + This options adds boot configuration that can run the FreeBSD > > The help text should be more descriptive and actually tell users what > the option really does. Ok will do that. > Since the only thing CONFIG_FREEBSD does now is > to enable distro boot support for it, maybe even rename the the option > into CONFIG_DISTRO_FREEBSD. We might want to support uImage/FIT at one point (I'm currently looking at this) so CONFIG_FREEBSD will make more sense. But we can rename the option later if needed, I don't know which way is better.
On 01/26/2017 06:44 PM, Emmanuel Vadot wrote: > On Thu, 26 Jan 2017 18:08:49 +0100 > Alexander Graf <agraf@suse.de> wrote: > >> On 01/26/2017 05:46 PM, Emmanuel Vadot wrote: >>> Add a FreeBSD option that enables the API and the data cache command >>> as both are needed to boot the FreeBSD loader. >>> >>> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> >>> --- >>> common/Kconfig | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/common/Kconfig b/common/Kconfig >>> index 9067d1e277..2fe19d354b 100644 >>> --- a/common/Kconfig >>> +++ b/common/Kconfig >>> @@ -430,4 +430,13 @@ config BOARD_EARLY_INIT_F >>> >>> endmenu >>> >>> +config FREEBSD >>> + bool "Enable FreeBSD boot" >>> + select API >>> + select CMD_CACHE >>> + default n >>> + help >>> + This options adds boot configuration that can run the FreeBSD >> The help text should be more descriptive and actually tell users what >> the option really does. > Ok will do that. > >> Since the only thing CONFIG_FREEBSD does now is >> to enable distro boot support for it, maybe even rename the the option >> into CONFIG_DISTRO_FREEBSD. > We might want to support uImage/FIT at one point (I'm currently > looking at this) so CONFIG_FREEBSD will make more sense. But we can > rename the option later if needed, I don't know which way is better. What do you need to change for uImage / FIT support? Does that have to be conditionalized? Alex
Am 26.01.2017 um 18:53 schrieb Alexander Graf: > On 01/26/2017 06:44 PM, Emmanuel Vadot wrote: >> On Thu, 26 Jan 2017 18:08:49 +0100 >> Alexander Graf <agraf@suse.de> wrote: >> >>> On 01/26/2017 05:46 PM, Emmanuel Vadot wrote: >>>> Add a FreeBSD option that enables the API and the data cache command >>>> as both are needed to boot the FreeBSD loader. >>>> >>>> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> >>>> --- >>>> common/Kconfig | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/common/Kconfig b/common/Kconfig >>>> index 9067d1e277..2fe19d354b 100644 >>>> --- a/common/Kconfig >>>> +++ b/common/Kconfig >>>> @@ -430,4 +430,13 @@ config BOARD_EARLY_INIT_F >>>> endmenu >>>> +config FREEBSD >>>> + bool "Enable FreeBSD boot" >>>> + select API >>>> + select CMD_CACHE >>>> + default n >>>> + help >>>> + This options adds boot configuration that can run the FreeBSD >>> The help text should be more descriptive and actually tell users what >>> the option really does. >> Ok will do that. >> >>> Since the only thing CONFIG_FREEBSD does now is >>> to enable distro boot support for it, maybe even rename the the option >>> into CONFIG_DISTRO_FREEBSD. >> We might want to support uImage/FIT at one point (I'm currently >> looking at this) so CONFIG_FREEBSD will make more sense. But we can >> rename the option later if needed, I don't know which way is better. > > What do you need to change for uImage / FIT support? Does that have to > be conditionalized? Or going further, is there a strict reason the distro changes need to be conditionalized at all? As long as they're properly guarded with checks for file existence it would only cost little boot time on a Linux system. If you think of systems where you place U-Boot onto the SD card along your OS code then for sure it's possible for FreeBSD to enable this CONFIG_FREEBSD option during its build; but if you think of devices where U-Boot is in flash then it seems weird to flash different U-Boot variants dependent on what operating system you plan to run. Regards, Andreas
diff --git a/common/Kconfig b/common/Kconfig index 9067d1e277..2fe19d354b 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -430,4 +430,13 @@ config BOARD_EARLY_INIT_F endmenu +config FREEBSD + bool "Enable FreeBSD boot" + select API + select CMD_CACHE + default n + help + This options adds boot configuration that can run the FreeBSD + loader. + source "common/spl/Kconfig"
Add a FreeBSD option that enables the API and the data cache command as both are needed to boot the FreeBSD loader. Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> --- common/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+)