| Message ID | 20170126164612.86684-2-manu@bidouilliste.com |
|---|---|
| State | Accepted |
| Commit | 4db98d3d92827e38d0853f0c1932d3db7d757622 |
| Delegated to: | Tom Rini |
| Headers | show |
Am 26.01.2017 um 17:46 schrieb Emmanuel Vadot: > Add kconfig file to enable API support > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > --- > Kconfig | 2 ++ > api/Kconfig | 9 +++++++++ > 2 files changed, 11 insertions(+) > create mode 100644 api/Kconfig No patch in this series updates the two boards Tom pointed out. Regards, Andreas
On Thu, 26 Jan 2017 18:17:47 +0100 Andreas Färber <afaerber@suse.de> wrote: > Am 26.01.2017 um 17:46 schrieb Emmanuel Vadot: > > Add kconfig file to enable API support > > > > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > > --- > > Kconfig | 2 ++ > > api/Kconfig | 9 +++++++++ > > 2 files changed, 11 insertions(+) > > create mode 100644 api/Kconfig > > No patch in this series updates the two boards Tom pointed out. > > Regards, > Andreas Once CONFIG_API is available I'll update the two boards. I don't think it make sense to convert them in the same patch series for FreeBSD. Cheers,
Am 26.01.2017 um 18:45 schrieb Emmanuel Vadot: > On Thu, 26 Jan 2017 18:17:47 +0100 > Andreas Färber <afaerber@suse.de> wrote: > >> Am 26.01.2017 um 17:46 schrieb Emmanuel Vadot: >>> Add kconfig file to enable API support >>> >>> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> >>> --- >>> Kconfig | 2 ++ >>> api/Kconfig | 9 +++++++++ >>> 2 files changed, 11 insertions(+) >>> create mode 100644 api/Kconfig >> >> No patch in this series updates the two boards Tom pointed out. > > Once CONFIG_API is available I'll update the two boards. Unless I'm misreading something, it is available since this patch. > I don't think it make sense to convert them in the same patch series > for FreeBSD. Personally I would expect this to be done in this patch that converts the pre-existing option. It's really small as is and so are the requested cleanups. (This patch/commit does not mention FreeBSD once, and, once merged, Git history will not tell what patchset it came from.) Cheers, Andreas
On Thu, Jan 26, 2017 at 07:00:23PM +0100, Andreas Färber wrote: > Am 26.01.2017 um 18:45 schrieb Emmanuel Vadot: > > On Thu, 26 Jan 2017 18:17:47 +0100 > > Andreas Färber <afaerber@suse.de> wrote: > > > >> Am 26.01.2017 um 17:46 schrieb Emmanuel Vadot: > >>> Add kconfig file to enable API support > >>> > >>> Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> > >>> --- > >>> Kconfig | 2 ++ > >>> api/Kconfig | 9 +++++++++ > >>> 2 files changed, 11 insertions(+) > >>> create mode 100644 api/Kconfig > >> > >> No patch in this series updates the two boards Tom pointed out. > > > > Once CONFIG_API is available I'll update the two boards. > > Unless I'm misreading something, it is available since this patch. > > > I don't think it make sense to convert them in the same patch series > > for FreeBSD. > > Personally I would expect this to be done in this patch that converts > the pre-existing option. It's really small as is and so are the > requested cleanups. (This patch/commit does not mention FreeBSD once, > and, once merged, Git history will not tell what patchset it came from.) Right. The expectation would be that since this patch introduces API into Kconfig, and it's a really easy conversion, we convert the two boards in question as well. If it doesn't apply cleanly when I'm applying it's easy enough that I'll just fix it. Thanks!
diff --git a/Kconfig b/Kconfig index cb19ce6f87..2073d933d9 100644 --- a/Kconfig +++ b/Kconfig @@ -307,6 +307,8 @@ config ARCH_FIXUP_FDT_MEMORY endmenu # Boot images +source "api/Kconfig" + source "common/Kconfig" source "cmd/Kconfig" diff --git a/api/Kconfig b/api/Kconfig new file mode 100644 index 0000000000..16731d3b4b --- /dev/null +++ b/api/Kconfig @@ -0,0 +1,9 @@ +menu "API" + +config API + bool "Enable U-Boot API" + default n + help + This option enables the U-Boot API. See api/README for more information. + +endmenu
Add kconfig file to enable API support Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> --- Kconfig | 2 ++ api/Kconfig | 9 +++++++++ 2 files changed, 11 insertions(+) create mode 100644 api/Kconfig