[RFC,5/5] arm: dts: genmai: Add SCIF2 pin group
diff mbox

Message ID 1485367787-8109-6-git-send-email-jacopo+renesas@jmondi.org
State New
Headers show

Commit Message

Jacopo Mondi Jan. 25, 2017, 6:09 p.m. UTC
Add  TxD and RxD pin configuration for SCIF2 serial communication
interface on r7s72100 Genmai board.

Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Sergei Shtylyov Jan. 26, 2017, 9:51 a.m. UTC | #1
On 1/25/2017 9:09 PM, Jacopo Mondi wrote:

> Add  TxD and RxD pin configuration for SCIF2 serial communication
> interface on r7s72100 Genmai board.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts
> index 118a8e2..ea649c7 100644
> --- a/arch/arm/boot/dts/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/r7s72100-genmai.dts
[...]
> @@ -34,6 +35,18 @@
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  	};
> +
> +};
> +
> +&pinctrl {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&scif2_pins>;
> +
> +	scif2_pins: serial2 {
> +		/* P3_0 as TxD2; P3_2 as RxD2 */
> +		renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>,

    The comma should be after the vendor prefix ("renesas").

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Jan. 30, 2017, 6:17 p.m. UTC | #2
Hello,

On Thursday 26 Jan 2017 12:51:03 Sergei Shtylyov wrote:
> On 1/25/2017 9:09 PM, Jacopo Mondi wrote:
> > Add  TxD and RxD pin configuration for SCIF2 serial communication
> > interface on r7s72100 Genmai board.
> > 
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> > 
> >  arch/arm/boot/dts/r7s72100-genmai.dts | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts
> > b/arch/arm/boot/dts/r7s72100-genmai.dts index 118a8e2..ea649c7 100644
> > --- a/arch/arm/boot/dts/r7s72100-genmai.dts
> > +++ b/arch/arm/boot/dts/r7s72100-genmai.dts
> 
> [...]
> 
> > @@ -34,6 +35,18 @@
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> >  	};
> > +

That's not needed.

> > +};
> > +
> > +&pinctrl {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&scif2_pins>;
> > +
> > +	scif2_pins: serial2 {
> > +		/* P3_0 as TxD2; P3_2 as RxD2 */
> > +		renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>,
> 
> The comma should be after the vendor prefix ("renesas").

And the "-rz" suffix isn't needed, "renesas,pins" will do.
Geert Uytterhoeven Jan. 30, 2017, 6:55 p.m. UTC | #3
Hi Laurent,

On Mon, Jan 30, 2017 at 7:17 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Thursday 26 Jan 2017 12:51:03 Sergei Shtylyov wrote:
>> On 1/25/2017 9:09 PM, Jacopo Mondi wrote:
>> > +&pinctrl {
>> > +   pinctrl-names = "default";
>> > +   pinctrl-0 = <&scif2_pins>;
>> > +
>> > +   scif2_pins: serial2 {
>> > +           /* P3_0 as TxD2; P3_2 as RxD2 */
>> > +           renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>,
>>
>> The comma should be after the vendor prefix ("renesas").
>
> And the "-rz" suffix isn't needed, "renesas,pins" will do.

Then it can just become "pins"? Or not?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts b/arch/arm/boot/dts/r7s72100-genmai.dts
index 118a8e2..ea649c7 100644
--- a/arch/arm/boot/dts/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/r7s72100-genmai.dts
@@ -11,6 +11,7 @@ 
 
 /dts-v1/;
 #include "r7s72100.dtsi"
+#include "include/dt-bindings/pinctrl/pinctrl-renesas-rz.h"
 
 / {
 	model = "Genmai";
@@ -34,6 +35,18 @@ 
 		#address-cells = <1>;
 		#size-cells = <1>;
 	};
+
+};
+
+&pinctrl {
+	pinctrl-names = "default";
+	pinctrl-0 = <&scif2_pins>;
+
+	scif2_pins: serial2 {
+		/* P3_0 as TxD2; P3_2 as RxD2 */
+		renesas-rz,pins = <RZ_PIN(3, 0) ALTERNATE_FUNC_6>,
+				  <RZ_PIN(3, 2) ALTERNATE_FUNC_4>;
+	};
 };
 
 &extal_clk {