| Message ID | 1485334353-26815-2-git-send-email-bharatku@xilinx.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On 25/01/17 08:52, Bharat Kumar Gogada wrote: > - Legacy interrupts are level triggered, virtual irq line of End > Point shows as edge in /proc/interrupts. > - Setting irq flags of virtual irq line of EP to level triggered > at the time of mapping. > > Signed-off-by: Bharat Kumar Gogada <bharatku@xilinx.com> > --- > drivers/pci/host/pcie-xilinx-nwl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c > index 6ac3e1d..1cddd1f 100644 > --- a/drivers/pci/host/pcie-xilinx-nwl.c > +++ b/drivers/pci/host/pcie-xilinx-nwl.c > @@ -434,6 +434,7 @@ static int nwl_legacy_map(struct irq_domain *domain, unsigned int irq, > { > irq_set_chip_and_handler(irq, &nwl_leg_irq_chip, handle_level_irq); > irq_set_chip_data(irq, domain->host_data); > + irq_set_status_flags(irq, IRQ_LEVEL); > > return 0; > } > As said in my previous review [1], this should be folded in the previous patch, as it doesn't make much sense on its own. Thanks, M. [1] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1316912.html
> > On 25/01/17 08:52, Bharat Kumar Gogada wrote: > > - Legacy interrupts are level triggered, virtual irq line of End Point > > shows as edge in /proc/interrupts. > > - Setting irq flags of virtual irq line of EP to level triggered at > > the time of mapping. > > > > Signed-off-by: Bharat Kumar Gogada <bharatku@xilinx.com> > > --- > > drivers/pci/host/pcie-xilinx-nwl.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/host/pcie-xilinx-nwl.c > > b/drivers/pci/host/pcie-xilinx-nwl.c > > index 6ac3e1d..1cddd1f 100644 > > --- a/drivers/pci/host/pcie-xilinx-nwl.c > > +++ b/drivers/pci/host/pcie-xilinx-nwl.c > > @@ -434,6 +434,7 @@ static int nwl_legacy_map(struct irq_domain > > *domain, unsigned int irq, { > > irq_set_chip_and_handler(irq, &nwl_leg_irq_chip, handle_level_irq); > > irq_set_chip_data(irq, domain->host_data); > > + irq_set_status_flags(irq, IRQ_LEVEL); > > > > return 0; > > } > > > > As said in my previous review [1], this should be folded in the previous patch, as > it doesn't make much sense on its own. > Agreed, will send in same previous patch. bharat -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c index 6ac3e1d..1cddd1f 100644 --- a/drivers/pci/host/pcie-xilinx-nwl.c +++ b/drivers/pci/host/pcie-xilinx-nwl.c @@ -434,6 +434,7 @@ static int nwl_legacy_map(struct irq_domain *domain, unsigned int irq, { irq_set_chip_and_handler(irq, &nwl_leg_irq_chip, handle_level_irq); irq_set_chip_data(irq, domain->host_data); + irq_set_status_flags(irq, IRQ_LEVEL); return 0; }
- Legacy interrupts are level triggered, virtual irq line of End Point shows as edge in /proc/interrupts. - Setting irq flags of virtual irq line of EP to level triggered at the time of mapping. Signed-off-by: Bharat Kumar Gogada <bharatku@xilinx.com> --- drivers/pci/host/pcie-xilinx-nwl.c | 1 + 1 file changed, 1 insertion(+)